Skip to content

Clarify GNU vs MSVC for Windows #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Livven opened this issue Mar 12, 2021 · 1 comment · Fixed by #2715
Closed

Clarify GNU vs MSVC for Windows #2693

Livven opened this issue Mar 12, 2021 · 1 comment · Fixed by #2715

Comments

@Livven
Copy link

Livven commented Mar 12, 2021

Describe the problem you are trying to solve

The book says:

On Windows, download and run the [rustup-init.exe built for i686-pc-windows-gnu target][setup]. In general, this is the build of rustup one should install on Windows. Despite being built against the GNU toolchain, the Windows build of rustup will install Rust for the MSVC toolchain if it detects that MSVC is installed.

However, the official Rust download page links to the MSVC version of rustup-init, going against the recommendation from the book.

Additionally, I ran the GNU version of rustup-init in a clean mcr.microsoft.com/windows:1809 Docker container, which does not have MSVC, as confirmed by the fact that cargo build tells me I am missing the linker, and yet I still get an MSVC toolchain by default.

So it seems that the book is wrong about the MSVC detection, or it does not work reliably.

Describe the solution you'd like

To me, it seems the correct solution would be to recommend the MSVC version of rustup-init, but in any case the recommendation from the book and official download link should probably be aligned.

Notes

See above.

@rbtcollins
Copy link
Contributor

I believe the book to be out of date: we decided to recommend the MSVC built rustup a long time ago. See #1353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants