Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squashing: recommend --keep-base when squashing without a conflict #2157

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 6, 2024

No description provided.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@jieyouxu jieyouxu merged commit 17a6c0b into rust-lang:master Dec 6, 2024
1 check passed
@jieyouxu
Copy link
Member

jieyouxu commented Dec 6, 2024

(You can self-merge, we don't have the 1-approval requirement anymore if u have write access)

@RalfJung
Copy link
Member Author

RalfJung commented Dec 7, 2024

I could but that doesn't mean I should. I'd rather have some double-check my edits and make sure there's not some context I am overlooking.

@RalfJung RalfJung deleted the git branch December 7, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants