Skip to content

Update cc-rs to 1.2.39 #146186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update cc-rs to 1.2.39 #146186

wants to merge 2 commits into from
+4 −3

Conversation

@dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Sep 4, 2025 •
edited
Loading

For my purposes, contains fixes when compiling the Rust compiler for Arm64EC.

Checked the commits since 1.2.16, and I don't see anything else that may affect Rust?

find-msvc-tools was also factored out from cc to allow updating the use in rustc_codegen_ssa (finding the linker when running the Rust compiler) to be separate from the use in rustc_llvm (building LLVM as part of the Rust compiler).

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

Failed to set assignee to NobodyXu: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@jieyouxu jieyouxu self-assigned this Sep 4, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Sep 4, 2025

@bors try jobs=aarch64-msvc-1,aarch64-apple,test-various,dist-apple-various

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 4, 2025
@rust-bors
Auto merge of #146186 - dpaoliello:cc, r=<try>
d8ac12e 
Update cc-rs to 1.2.33

try-job: aarch64-msvc-1
try-job: aarch64-apple
try-job: test-various
try-job: dist-apple-various
@rust-bors
Copy link

rust-bors bot commented Sep 4, 2025

☀️ Try build successful (CI)
Build commit: d8ac12e (d8ac12e3b0cef5271092800d62ab852417973355, parent: a1208bf765ba783ee4ebdc4c29ab0a0c215806ef)

NobodyXu
NobodyXu reviewed Sep 4, 2025
View reviewed changes
@jieyouxu
Copy link
Member

jieyouxu commented Sep 4, 2025

Let me know @dpaoliello if you want to try with find-msvc-tools, otherwise I'm fine with the current change as well.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot

This comment has been minimized.

Sign in to view
@dpaoliello dpaoliello changed the title Update cc-rs to 1.2.33 Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools Sep 4, 2025
@dpaoliello
Copy link
Contributor Author

I switched to find-msvc-tools, since I was here changing things.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@davidtwco
Copy link
Member

@bors r=davidtwco,jieyouxu

@bors
Copy link
Collaborator

bors commented Sep 4, 2025

📌 Commit 45a0e10 has been approved by davidtwco,jieyouxu

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2025
@dpaoliello
Copy link
Contributor Author

@bors try cancel

@rust-bors
Copy link

rust-bors bot commented Sep 23, 2025

Try build cancelled. Cancelled workflows:

@dpaoliello
Copy link
Contributor Author

@bors2 try jobs=dist-aarch64-linux

rust-bors bot added a commit that referenced this pull request Sep 23, 2025
@rust-bors
Auto merge of #146186 - dpaoliello:cc, r=<try>
70c9139 
Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools

try-job: dist-aarch64-linux
@rust-bors

This comment has been minimized.

Sign in to view
@dpaoliello dpaoliello mentioned this pull request Sep 23, 2025
Closed
@dpaoliello
Copy link
Contributor Author

Current test build using a patched version of jemalloc to strip the -flto arg is part the point-of-failure, so submitted an upstream PR: tikv/jemallocator#144

@rust-bors
Copy link

rust-bors bot commented Sep 24, 2025

☀️ Try build successful (CI)
Build commit: 70c9139 (70c9139e1af293ca2c92ec727e21cbdba4170b73, parent: 975e6c8fec280816d24fbde6b8dfe19620f2efe6)

@dpaoliello dpaoliello changed the title Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools Update cc-rs to 1.2.33 Sep 25, 2025
@dpaoliello dpaoliello changed the title Update cc-rs to 1.2.33 Update cc-rs to 1.2.39 Oct 23, 2025
@dpaoliello
Copy link
Contributor Author

@bors2 try jobs=dist-aarch64-linux,aarch64-msvc-1,aarch64-apple,test-various,dist-apple-various

rust-bors bot added a commit that referenced this pull request Oct 24, 2025
@rust-bors
Auto merge of #146186 - dpaoliello:cc, r=<try>
9cd2e4c 
Update cc-rs to 1.2.39

try-job: dist-aarch64-linux
try-job: aarch64-msvc-1
try-job: aarch64-apple
try-job: test-various
try-job: dist-apple-various
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Oct 24, 2025

💔 Test for 9cd2e4c failed: CI. Failed jobs:

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@dpaoliello
Copy link
Contributor Author

try failure looks like a docker timeout.

Retrying...
@bors2 try jobs=dist-aarch64-linux,aarch64-msvc-1,aarch64-apple,test-various,dist-apple-various

rust-bors bot added a commit that referenced this pull request Oct 24, 2025
@rust-bors
Auto merge of #146186 - dpaoliello:cc, r=<try>
c2755aa 
Update cc-rs to 1.2.39

try-job: dist-aarch64-linux
try-job: aarch64-msvc-1
try-job: aarch64-apple
try-job: test-various
try-job: dist-apple-various
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Oct 24, 2025

☀️ Try build successful (CI)
Build commit: c2755aa (c2755aadb42e9221ae8576d267a57d65307ee733, parent: ab925646fae038b02bd462cd328ae9eef1639236)

@dpaoliello dpaoliello marked this pull request as ready for review October 24, 2025 20:35
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2025
@dpaoliello
Copy link
Contributor Author

@rustbot ready

@jieyouxu
Copy link
Member

@dpaoliello could you squash the commits and fixup the commit message to say 1.2.39 instead of 1.2.33 (from the previous attempts)? Otherwise, this looks good to me.

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

@davidtwco davidtwco davidtwco approved these changes

+2 more reviewers

@lambdageek lambdageek lambdageek left review comments

@NobodyXu NobodyXu NobodyXu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jieyouxu jieyouxu

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@dpaoliello @rustbot @jieyouxu @rust-log-analyzer @davidtwco @bors @tgross35 @lambdageek @NobodyXu