Skip to content

Stabilize const_float_round_methods #143604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stabilize const_float_round_methods #143604

wants to merge 2 commits into from
+32 −38

Conversation

nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Jul 7, 2025 •
edited
Loading

Closes #141555, waiting for FCP.

@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 7, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nxsaken nxsaken force-pushed the const_float_round_methods branch from 2fc9d9b to 5df1124 Compare July 7, 2025 19:39
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nxsaken nxsaken marked this pull request as draft July 7, 2025 19:56
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2025
@nxsaken nxsaken force-pushed the const_float_round_methods branch from 5df1124 to c7002be Compare July 7, 2025 20:24
@nxsaken nxsaken marked this pull request as ready for review July 7, 2025 21:04
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2025

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

nxsaken
nxsaken commented Jul 7, 2025
View reviewed changes
@traviscross traviscross added T-lang Relevant to the language team I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Jul 9, 2025
@traviscross

This comment was marked as duplicate.

Sign in to view
@rfcbot

This comment was marked as duplicate.

Sign in to view
@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2025
@traviscross

This comment was marked as resolved.

Sign in to view
@rfcbot

This comment was marked as resolved.

Sign in to view
@rfcbot rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2025
@traviscross traviscross removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 9, 2025
@traviscross
Copy link
Contributor

Thanks to @nxsaken for putting up the stabilization PR.

@rfcbot fcp merge

cc @rust-lang/lang @rust-lang/opsem @RalfJung @rust-lang/libs-api

@rfcbot
Copy link
Collaborator

rfcbot commented Jul 9, 2025 •
edited by joshtriplett
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2025
@tmandry
Copy link
Member

tmandry commented Jul 9, 2025

@rfcbot reviewed

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 9, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented Jul 9, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@traviscross traviscross mentioned this pull request Jul 9, 2025
Open
5 tasks
@traviscross traviscross added I-lang-radar Items that are on lang's radar and will need eventual work or consideration. and removed P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang I-lang-nominated Nominated for discussion during a lang team meeting. labels Jul 9, 2025
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jul 19, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented Jul 19, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rustbot rustbot mentioned this pull request Jul 19, 2025
Closed
@RalfJung
Copy link
Member

@nxsaken please rebase to resolve the conflicts, then we can land this :)

@nxsaken nxsaken force-pushed the const_float_round_methods branch from c7002be to caf4f11 Compare July 19, 2025 20:10
@RalfJung
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 19, 2025

📌 Commit caf4f11 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for #![feature(const_float_round_methods)]
9 participants
@nxsaken @rustbot @rust-log-analyzer @traviscross @rfcbot @tmandry @RalfJung @bors @Mark-Simulacrum