-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
C-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
The defaults are a lot better after #73964, but they still aren't ideal for everyone. Some issues that have been mentioned:
x.py test
does not runui-fulldeps
(and inherently can't with--stage 1
): Ignore gated-plugin test on stage1 #75404 (comment)x.py doc
uses stage 0 by default which is not my preference, I almost always want---stage 1
. But new contributors will normally want--stage 0
, so it doesn't make sense to change it for everyone.
It would be great to allow configuring the default stage on a per-subcommand level. This would both make it easier to add new commands to the test suite (e.g. #70533 (comment)), and more convenient for local contributors who want defaults other than those hardcoded into bootstrap. The existing defaults could still be left in config.toml.example
, making this backwards-compatible for contributors.
mark-i-m
Metadata
Metadata
Assignees
Labels
C-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)