-
Notifications
You must be signed in to change notification settings - Fork 13.3k
building rustc with autodiff and debug enabled fails. #139704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@rustbot claim |
@Shourya742 Since you still have the other open issue and I had some time today, I looked into it. |
That’s cool—I can help test and review it then. Naive me was going through all the commits that changed that file one by one, and each build took around 20 minutes to complete. Is there any way we can reduce the build time? |
Oh it's just a one line fix, so no need to review or test, oli should approve it soon. I am looking into some ways to improve bootstrap time and another person also wanted to check something related, I think it's better if not too many people work on it to avoid duplications. If you look for other issues, it looks like no one is currently working on this one: EnzymeAD#193 (support for |
I can take this up. While more challenging issues might take some time, they will provide a great learning opportunity, and I'm ready for them. Pure Rust tasks can also be assigned — I have some time next week |
Rollup merge of rust-lang#140030 - EnzymeAD:autodiff-debug, r=jieyouxu Fix autodiff debug builds r? `@oli-obk` closes: rust-lang#139704 Tracking: - rust-lang#124509
I tried this code:
I expected to see this happen: builds rustc
Instead, this happened:
Meta
rustc --version --verbose
:I know that debug builds used to work a few months ago.
So one could try to debug this by looking at the code. A much simpler solution probably is just
to do some binary search by building some older PR from the tracking issue with debug=true until finding one that builds. From there it should be easy to figure out which PR introduced the bug. Once that's clear it is hopefully easier to understand which change introduced the bug, and either directly fix it, or ask for help here or in the zulip channel. I'm marking it as easy, since it takes a bit of time to test multiple PRs but it isn't overly complex, and we had support for it and didn't introduce overly complex code changes in the last months. So the fix is likely also comparably simple.
This bug prevents us from enabling autodiff in CI and thus nightly, so any help would be appreciated!
Backtrace
The text was updated successfully, but these errors were encountered: