Skip to content

Tracking issue for release notes of #127581: Fix crate name validation #137137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 3 tasks
fmease opened this issue Feb 16, 2025 · 2 comments
Open
1 of 3 tasks

Tracking issue for release notes of #127581: Fix crate name validation #137137

fmease opened this issue Feb 16, 2025 · 2 comments
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@fmease
Copy link
Member

fmease commented Feb 16, 2025

This issue tracks the release notes text for #127581.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Compatibility notes
- [Rust now raises an error for macro invocations inside the `#![crate_name]` attribute](https://github.com/rust-lang/rust/pull/127581)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @fmease, @bjorn3 -- origin issue/PR authors and assignees for starting to draft text

@fmease fmease added relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 16, 2025
@fmease fmease added this to the 1.86.0 milestone Feb 16, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 16, 2025
@fmease fmease removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 16, 2025
@fmease
Copy link
Member Author

fmease commented Feb 16, 2025

(This relnotes tracking issue was created manually because the PR predates the rustbot handler and I wasn't sure if T-release still looks at relnotes PRs w/o a corresp. relnotes tracking issue)

@cuviper cuviper modified the milestones: 1.86.0, 1.87.0 Feb 16, 2025
@cuviper
Copy link
Member

cuviper commented Feb 16, 2025

FYI, I moved this to 1.87 because it landed after the version bump -- that's a rustbot bug with rollups on the cusp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants