-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Support individual files for clippy tests #104200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
FTR this is also badly documented in clippy itself. You can't find it in the contributor instructions for example. It's also not printed by compiletest when it says "if you want to re-run the test do X" (that gives you a wrong command). |
@est31 you should report that on the clippy repo. |
@jyn514 fair. Done: rust-lang/rust-clippy#9825 |
@rustbot claim |
Triage: clippy no longer uses compiletest (it uses |
IIRC |
@rustbot claim |
Clippy is a special snowflake and uses
TESTNAME
to tell it how to run individual tests instead of an argument to compiletest. Currently the only way to run individual tests is withTESTNAME=ice-6250 x test src/tools/clippy --bless
. We should supportx test src/tools/clippy/tests/ice-6250.rs
as well.#103266 will help simplify this a little by supporting the same test arguments as in-tree compiletest, but it won't solve suite paths automatically. Suite code lives around https://github.com/rust-lang/rust/blob/51de2387dc8b0871a7bbb58f0c73ea7ca1d339e4/src/bootstrap/builder.rs#L480 - maybe we need to change
impl Step for Clippy
to usesuite_path
?Originally posted by @jyn514 in #103636 (comment)
The text was updated successfully, but these errors were encountered: