Skip to content

Commit 4b26d9c

Browse files
committed
User should not change between emcc install and use
1 parent 36808c2 commit 4b26d9c

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

src/ci/docker/asmjs/Dockerfile

+3-1
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,15 @@ ENV PATH=$PATH:/emsdk-portable
2424
ENV PATH=$PATH:/emsdk-portable/upstream/emscripten/
2525
ENV PATH=$PATH:/emsdk-portable/node/12.9.1_64bit/bin/
2626
ENV BINARYEN_ROOT=/emsdk-portable/upstream/
27-
ENV EM_CONFIG=/emsdk-portable/.emscripten
2827

2928
ENV TARGETS=asmjs-unknown-emscripten
3029

3130
# Use -O1 optimizations in the link step to reduce time spent optimizing JS.
3231
ENV EMCC_CFLAGS=-O1
3332

33+
# Emscripten installation is user-specific
34+
ENV NO_CHANGE_USER=1
35+
3436
ENV SCRIPT python2.7 ../x.py test --target $TARGETS
3537

3638
# This is almost identical to the wasm32-unknown-emscripten target, so

src/ci/docker/scripts/emscripten.sh

-10
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,3 @@ git clone https://github.com/emscripten-core/emsdk.git /emsdk-portable
2121
cd /emsdk-portable
2222
hide_output ./emsdk install 1.38.46-upstream
2323
./emsdk activate 1.38.46-upstream
24-
25-
# Compile and cache libc
26-
source ./emsdk_env.sh
27-
echo "main(){}" > a.c
28-
HOME=/emsdk-portable/ emcc a.c
29-
rm -f a.*
30-
31-
# Make emsdk usable by any user
32-
cp /root/.emscripten /emsdk-portable
33-
chmod a+rxw -R /emsdk-portable

src/ci/docker/wasm32/Dockerfile

+3-1
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,15 @@ ENV PATH=$PATH:/emsdk-portable
2424
ENV PATH=$PATH:/emsdk-portable/upstream/emscripten/
2525
ENV PATH=$PATH:/emsdk-portable/node/12.9.1_64bit/bin/
2626
ENV BINARYEN_ROOT=/emsdk-portable/upstream/
27-
ENV EM_CONFIG=/emsdk-portable/.emscripten
2827

2928
ENV TARGETS=wasm32-unknown-emscripten
3029

3130
# Use -O1 optimizations in the link step to reduce time spent optimizing.
3231
ENV EMCC_CFLAGS=-O1
3332

33+
# Emscripten installation is user-specific
34+
ENV NO_CHANGE_USER=1
35+
3436
# FIXME: Re-enable these tests once https://github.com/rust-lang/cargo/pull/7476
3537
# is picked up by CI
3638
ENV SCRIPT python2.7 ../x.py test --target $TARGETS \

0 commit comments

Comments
 (0)