Skip to content

Commit 45dc52c

Browse files
committed
remove 32-bit arm HelenOS for now
See also notes in the PR, I was unable to run anything non-trivial on ARM HelenOS, there are issues with the linker/loader, incomplete support of atomics, and overall a lot of confusion about the precise version of ARM architecture that the HelenOS builds target.
1 parent 9f52ca1 commit 45dc52c

File tree

6 files changed

+1
-46
lines changed

6 files changed

+1
-46
lines changed

compiler/rustc_target/src/spec/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1842,7 +1842,6 @@ supported_targets! {
18421842
("x86_64-unknown-haiku", x86_64_unknown_haiku),
18431843

18441844
("aarch64-unknown-helenos", aarch64_unknown_helenos),
1845-
("armv5te-unknown-helenos-eabi", armv5te_unknown_helenos_eabi),
18461845
("i686-unknown-helenos", i686_unknown_helenos),
18471846
("powerpc-unknown-helenos", powerpc_unknown_helenos),
18481847
("sparc64-unknown-helenos", sparc64_unknown_helenos),

compiler/rustc_target/src/spec/targets/armv5te_unknown_helenos_eabi.rs

Lines changed: 0 additions & 35 deletions
This file was deleted.

src/bootstrap/src/core/sanity.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ pub struct Finder {
3434
// Targets can be removed from this list once they are present in the stage0 compiler (usually by updating the beta compiler of the bootstrap).
3535
const STAGE0_MISSING_TARGETS: &[&str] = &[
3636
"aarch64-unknown-helenos",
37-
"armv5te-unknown-helenos-eabi",
3837
"i686-unknown-helenos",
3938
"x86_64-unknown-helenos",
4039
"powerpc-unknown-helenos",

src/doc/rustc/src/platform-support.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,6 @@ target | std | host | notes
283283
[`armv4t-none-eabi`](platform-support/armv4t-none-eabi.md) | * | | Bare Armv4T
284284
`armv4t-unknown-linux-gnueabi` | ? | | Armv4T Linux
285285
[`armv5te-none-eabi`](platform-support/armv5te-none-eabi.md) | * | | Bare Armv5TE
286-
[`armv5te-unknown-helenos-eabi`](platform-support/helenos.md) | ✓ | | Armv5TE HelenOS (see docs for pending issues)
287286
`armv5te-unknown-linux-uclibceabi` | ? | | Armv5TE Linux with uClibc
288287
[`armv6-unknown-freebsd`](platform-support/freebsd.md) | ✓ | ✓ | Armv6 FreeBSD
289288
[`armv6-unknown-netbsd-eabihf`](platform-support/netbsd.md) | ✓ | ✓ | Armv6 NetBSD w/hard-float

src/doc/rustc/src/platform-support/helenos.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,11 @@ Target triplets available:
1212
- `powerpc-unknown-helenos`
1313
- `aarch64-unknown-helenos`
1414
- `i686-unknown-helenos`*
15-
- `armv5te-unknown-helenos`*
1615

17-
Support of the latter two platforms is available in the compiler, however, the toolchains are not fully functional:
1816

19-
- On i686, some portions of native HelenOS libraries run into issues due to vector instructions accessing variables from stack that seems
17+
On i686, some portions of native HelenOS libraries run into issues due to vector instructions accessing variables from the stack that seems
2018
to be misaligned. It is not clear if this is fault of HelenOS or Rust. Most programs work, but for example calling `ui_window_create` from HelenOS
2119
libui does not work.
22-
- On 32-bit Arm, HelenOS libc is missing atomic primitives, and even after attempting to fill them, the resulting executables weren't functional,
23-
again for reasons that weren't fully understood yet.
2420

2521
## Target maintainers
2622

tests/assembly/targets/targets-elf.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,6 @@
118118
//@ revisions: armv5te_none_eabi
119119
//@ [armv5te_none_eabi] compile-flags: --target armv5te-none-eabi
120120
//@ [armv5te_none_eabi] needs-llvm-components: arm
121-
//@ revisions: armv5te_unknown_helenos_eabi
122-
//@ [armv5te_unknown_helenos_eabi] compile-flags: --target armv5te-unknown-helenos-eabi
123-
//@ [armv5te_unknown_helenos_eabi] needs-llvm-components: arm
124121
//@ revisions: armv5te_unknown_linux_gnueabi
125122
//@ [armv5te_unknown_linux_gnueabi] compile-flags: --target armv5te-unknown-linux-gnueabi
126123
//@ [armv5te_unknown_linux_gnueabi] needs-llvm-components: arm

0 commit comments

Comments
 (0)