Skip to content

Broken suggestion for const_static_lifetime #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
killercup opened this issue Jan 16, 2018 · 2 comments · Fixed by #2366
Closed

Broken suggestion for const_static_lifetime #2365

killercup opened this issue Jan 16, 2018 · 2 comments · Fixed by #2366
Labels
C-bug Category: Clippy is not doing the correct thing good-first-issue These issues are a good way to get started with Clippy

Comments

@killercup
Copy link
Member

The suggestion for const_static_lifetime currently only removes 'static from &'static str and leaves a space between & and str.

cf. https://github.com/killercup/rustfix/pull/49
@killercup
Copy link
Member Author

rust-lang/rust#47465 reminded of this (and that I never documented it)

@oli-obk oli-obk added C-bug Category: Clippy is not doing the correct thing good-first-issue These issues are a good way to get started with Clippy labels Jan 16, 2018
Manishearth added a commit that referenced this issue Jan 16, 2018
@Manishearth
Show wider and more accurate suggestion for const_static_lifetime
37f62a5 
fixes #2365
@Manishearth Manishearth mentioned this issue Jan 16, 2018
Merged
@Manishearth
Copy link
Member

#2366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: Clippy is not doing the correct thing good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show wider and more accurate suggestion for const_static_lifetime rust-lang/rust-clippy
3 participants
@killercup @oli-obk @Manishearth