@rustbot claim

Hi, @ulrichstark .
Could you tell me the clippy suggestions?
I tried running Clippy, and the suggestion can be compiled.

Rust Playground

I'm using rust-analyzer's quick fix "try: results.into_iter().flatten()" in VS Code.
It's only replacing results with results.into_iter().flatten(), but not removing the if.
Is this instead just an issue with rust-analyzer only applying the first suggestion of clippy?

Clippy suggestion:

warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
 --> src\main.rs:4:5
  |
4 |       for result in results {
  |       ^             ------- help: try: `results.into_iter().flatten()`
  |  _____|
  | |
5 | |         if let Ok(value) = result {
6 | |             println!("{value}");
7 | |         }
8 | |     }
  | |_____^
  |
help: ...and remove the `if let` statement in the for loop
 --> src\main.rs:5:9
  |
5 | /         if let Ok(value) = result {
6 | |             println!("{value}");
7 | |         }
  | |_________^
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
  = note: `#[warn(clippy::manual_flatten)]` on by default

Thank you for the additional information!
I think this problem comes from clippy because if let part is the help message which does not fix the original code.

If the suggestion is incomplete and cannot be completed, it should probably be MachineApplicable::HasPlaceholders.

While that would stop RA from suggesting it as a code action it's more of a workaround, it doesn't actually contain any placeholders

The core issue being that it emits a suggestion and a help message where it should be a single multipart suggestion

Of course, emitting a correct and complete suggestion would be even better (that's what I wrote above in "if the suggestion is incomplete and cannot be completed").