Skip to content

Commit

Permalink
Update known problems for default_numeric_fallback (#13794)
Browse files Browse the repository at this point in the history
The existing known problem is not actually true, and the many false
positives and false negatives should be mentioned.

Allowing the lint on a single statement:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=328de43690af13ed126f7c00c15cd695

changelog: [`default_numeric_fallback`]: update known problems docs
  • Loading branch information
Centri3 authored Dec 8, 2024
2 parents 7f866c7 + 0a99eec commit d1e1aff
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions clippy_lints/src/default_numeric_fallback.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ declare_clippy_lint! {
/// To ensure that every numeric type is chosen explicitly rather than implicitly.
///
/// ### Known problems
/// This lint can only be allowed at the function level or above.
/// This lint is implemented using a custom algorithm independent of rustc's inference,
/// which results in many false positives and false negatives.
///
/// ### Example
/// ```no_run
Expand All @@ -36,8 +37,8 @@ declare_clippy_lint! {
///
/// Use instead:
/// ```no_run
/// let i = 10i32;
/// let f = 1.23f64;
/// let i = 10_i32;
/// let f = 1.23_f64;
/// ```
#[clippy::version = "1.52.0"]
pub DEFAULT_NUMERIC_FALLBACK,
Expand Down

0 comments on commit d1e1aff

Please sign in to comment.