Skip to content

Commit b871e39

Browse files
committed
Rebase attempt 3
1 parent 24d16ee commit b871e39

File tree

321 files changed

+4
-34111
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

321 files changed

+4
-34111
lines changed

CHANGELOG.md

-147
Original file line numberDiff line numberDiff line change
@@ -71,27 +71,9 @@ If you have any feedback related to the new format, please share it in
7171

7272
## Rust 1.70
7373

74-
<<<<<<< HEAD
75-
<<<<<<< HEAD
7674
Released 2023-06-01
7775

7876
[View all 91 merged pull requests](https://github.com/rust-lang/rust-clippy/pulls?q=merged%3A2023-02-26T01%3A05%3A43Z..2023-04-11T13%3A27%3A30Z+base%3Amaster)
79-
=======
80-
<<<<<<< HEAD
81-
<<<<<<< HEAD
82-
<<<<<<< HEAD
83-
Current stable, released 2023-06-01
84-
=======
85-
=======
86-
>>>>>>> 615b25c20 (Rebase attempt number 2)
87-
Released 2023-06-01
88-
89-
[View all 91 merged pull requests](https://github.com/rust-lang/rust-clippy/pulls?q=merged%3A2023-02-26T01%3A05%3A43Z..2023-04-11T13%3A27%3A30Z+base%3Amaster)
90-
<<<<<<< HEAD
91-
>>>>>>> 28655266b (Fix changelog PR listings, create them automatically in `fetch_prs_between.sh`)
92-
>>>>>>> 0567691cb (This commit resolves issue #10655)
93-
=======
94-
>>>>>>> 615b25c20 (Rebase attempt number 2)
9577

9678
### New Lints
9779

@@ -149,23 +131,7 @@ Released 2023-06-01
149131
[#10309](https://github.com/rust-lang/rust-clippy/pull/10309)
150132
* [`items_after_statements`]: `#[allow(items_after_statements)]` now works on items
151133
[#10542](https://github.com/rust-lang/rust-clippy/pull/10542)
152-
<<<<<<< HEAD
153-
<<<<<<< HEAD
154-
* [`significant_drop_tightening`]: Was optimized
155-
=======
156-
<<<<<<< HEAD
157-
<<<<<<< HEAD
158134
* [`significant_drop_tightening`]: Was optimized
159-
=======
160-
* [`significant_drop_tightening`]: was optimized
161-
>>>>>>> 4d9303df1 (Changelog for Rust 1.70 :hammer:)
162-
=======
163-
* [`significant_drop_tightening`]: Was optimized
164-
>>>>>>> 7dd0ae026 (Change changelog typos)
165-
>>>>>>> 0567691cb (This commit resolves issue #10655)
166-
=======
167-
* [`significant_drop_tightening`]: Was optimized
168-
>>>>>>> 615b25c20 (Rebase attempt number 2)
169135
[#10533](https://github.com/rust-lang/rust-clippy/pull/10533)
170136

171137
### False Positive Fixes
@@ -186,38 +152,11 @@ Released 2023-06-01
186152
[#10527](https://github.com/rust-lang/rust-clippy/pull/10527)
187153
* [`needless_return`]: No longer lints match statements with incompatible branches
188154
[#10593](https://github.com/rust-lang/rust-clippy/pull/10593)
189-
<<<<<<< HEAD
190-
<<<<<<< HEAD
191-
=======
192-
<<<<<<< HEAD
193-
<<<<<<< HEAD
194-
>>>>>>> 0567691cb (This commit resolves issue #10655)
195-
=======
196-
>>>>>>> 615b25c20 (Rebase attempt number 2)
197155
* [`use_self`]: Do not suggest using `Self` in const generic parameters
198156
[#10375](https://github.com/rust-lang/rust-clippy/pull/10375)
199157
* [`mem_replace_option_with_none`]: No longer lints on field expressions
200158
[#10594](https://github.com/rust-lang/rust-clippy/pull/10594)
201159
* [`items_after_statements`]: No longer lints on items from macros
202-
<<<<<<< HEAD
203-
<<<<<<< HEAD
204-
=======
205-
<<<<<<< HEAD
206-
=======
207-
* [`use_self`]: do not suggest using `Self` in const generic parameters
208-
=======
209-
* [`use_self`]: Do not suggest using `Self` in const generic parameters
210-
>>>>>>> 7dd0ae026 (Change changelog typos)
211-
[#10375](https://github.com/rust-lang/rust-clippy/pull/10375)
212-
* [`mem_replace_option_with_none`]: No longer lints on field expressions
213-
[#10594](https://github.com/rust-lang/rust-clippy/pull/10594)
214-
* [`items_after_statements`]: No longer lints on times from macros
215-
>>>>>>> 4d9303df1 (Changelog for Rust 1.70 :hammer:)
216-
=======
217-
>>>>>>> a28eb5995 (Update *Current stable* text in `CHANGELOG.md`)
218-
>>>>>>> 0567691cb (This commit resolves issue #10655)
219-
=======
220-
>>>>>>> 615b25c20 (Rebase attempt number 2)
221160
[#10542](https://github.com/rust-lang/rust-clippy/pull/10542)
222161
* [`print_literal`], [`write_literal`]: No longer lint strings coming from the `file!()` macro
223162
[#10573](https://github.com/rust-lang/rust-clippy/pull/10573)
@@ -309,19 +248,7 @@ Released 2023-04-20
309248

310249
* [`explicit_auto_deref`]: Now considers projections when determining if auto deref is applicable
311250
[#10386](https://github.com/rust-lang/rust-clippy/pull/10386)
312-
<<<<<<< HEAD
313-
<<<<<<< HEAD
314251
* [`manual_let_else`]: Now considers side effects of branches before linting
315-
=======
316-
<<<<<<< HEAD
317-
* [`manual_let_else`]: Now considers side effects of branches before linting
318-
=======
319-
* [`manual_let_else`]: Now considers side effects of branches before linting
320-
>>>>>>> 7e9abb311 (Merge commit '371120bdbf58a331db5dcfb2d9cddc040f486de8' into clippyup)
321-
>>>>>>> 0567691cb (This commit resolves issue #10655)
322-
=======
323-
* [`manual_let_else`]: Now considers side effects of branches before linting
324-
>>>>>>> 615b25c20 (Rebase attempt number 2)
325252
[#10336](https://github.com/rust-lang/rust-clippy/pull/10336)
326253
* [`uninlined_format_args`]: No longer lints for arguments with generic parameters
327254
[#10343](https://github.com/rust-lang/rust-clippy/pull/10343)
@@ -4893,23 +4820,7 @@ Released 2018-09-13
48934820
[`erasing_op`]: https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op
48944821
[`err_expect`]: https://rust-lang.github.io/rust-clippy/master/index.html#err_expect
48954822
[`eval_order_dependence`]: https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence
4896-
<<<<<<< HEAD
4897-
<<<<<<< HEAD
4898-
[`excessive_nesting`]: https://rust-lang.github.io/rust-clippy/master/index.html#excessive_nesting
4899-
=======
4900-
<<<<<<< HEAD
4901-
<<<<<<< HEAD
49024823
[`excessive_nesting`]: https://rust-lang.github.io/rust-clippy/master/index.html#excessive_nesting
4903-
=======
4904-
[`excessive_indentation`]: https://rust-lang.github.io/rust-clippy/master/index.html#excessive_indentation
4905-
>>>>>>> 97c10075e (add the `excessive_*` style lints)
4906-
=======
4907-
[`excessive_nesting`]: https://rust-lang.github.io/rust-clippy/master/index.html#excessive_nesting
4908-
>>>>>>> e68dbc330 (add `excessive_nesting`)
4909-
>>>>>>> 0567691cb (This commit resolves issue #10655)
4910-
=======
4911-
[`excessive_nesting`]: https://rust-lang.github.io/rust-clippy/master/index.html#excessive_nesting
4912-
>>>>>>> 615b25c20 (Rebase attempt number 2)
49134824
[`excessive_precision`]: https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
49144825
[`exhaustive_enums`]: https://rust-lang.github.io/rust-clippy/master/index.html#exhaustive_enums
49154826
[`exhaustive_structs`]: https://rust-lang.github.io/rust-clippy/master/index.html#exhaustive_structs
@@ -5076,23 +4987,7 @@ Released 2018-09-13
50764987
[`manual_non_exhaustive`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive
50774988
[`manual_ok_or`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_or
50784989
[`manual_range_contains`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
5079-
<<<<<<< HEAD
5080-
<<<<<<< HEAD
5081-
[`manual_range_patterns`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
5082-
=======
5083-
<<<<<<< HEAD
5084-
<<<<<<< HEAD
5085-
[`manual_range_patterns`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
5086-
=======
5087-
[`manual_range_pattern`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_pattern
5088-
>>>>>>> 1d4afc5d8 (new lint: `manual_range_pattern`)
5089-
=======
50904990
[`manual_range_patterns`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
5091-
>>>>>>> b592d3996 (manual_range_pattern -> manual_range_patterns)
5092-
>>>>>>> 0567691cb (This commit resolves issue #10655)
5093-
=======
5094-
[`manual_range_patterns`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
5095-
>>>>>>> 615b25c20 (Rebase attempt number 2)
50964991
[`manual_rem_euclid`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_rem_euclid
50974992
[`manual_retain`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain
50984993
[`manual_saturating_arithmetic`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic
@@ -5196,22 +5091,7 @@ Released 2018-09-13
51965091
[`needless_question_mark`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
51975092
[`needless_range_loop`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
51985093
[`needless_raw_string_hashes`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
5199-
<<<<<<< HEAD
5200-
<<<<<<< HEAD
5201-
[`needless_raw_strings`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_strings
5202-
=======
5203-
<<<<<<< HEAD
5204-
<<<<<<< HEAD
5205-
[`needless_raw_strings`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_strings
5206-
=======
5207-
>>>>>>> 1bf74fc30 (add `needless_raw_string_hashes` lint)
5208-
=======
52095094
[`needless_raw_strings`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_strings
5210-
>>>>>>> 8cb6c8699 (change category and refactor)
5211-
>>>>>>> 0567691cb (This commit resolves issue #10655)
5212-
=======
5213-
[`needless_raw_strings`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_strings
5214-
>>>>>>> 615b25c20 (Rebase attempt number 2)
52155095
[`needless_return`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
52165096
[`needless_splitn`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn
52175097
[`needless_update`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
@@ -5580,34 +5460,7 @@ Released 2018-09-13
55805460
[`allow-private-module-inception`]: https://doc.rust-lang.org/clippy/lint_configuration.html#allow-private-module-inception
55815461
[`allowed-idents-below-min-chars`]: https://doc.rust-lang.org/clippy/lint_configuration.html#allowed-idents-below-min-chars
55825462
[`min-ident-chars-threshold`]: https://doc.rust-lang.org/clippy/lint_configuration.html#min-ident-chars-threshold
5583-
<<<<<<< HEAD
5584-
<<<<<<< HEAD
5585-
[`accept-comment-above-statement`]: https://doc.rust-lang.org/clippy/lint_configuration.html#accept-comment-above-statement
5586-
[`accept-comment-above-attributes`]: https://doc.rust-lang.org/clippy/lint_configuration.html#accept-comment-above-attributes
5587-
[`allow-one-hash-in-raw-strings`]: https://doc.rust-lang.org/clippy/lint_configuration.html#allow-one-hash-in-raw-strings
5588-
=======
5589-
<<<<<<< HEAD
5590-
<<<<<<< HEAD
5591-
=======
5592-
>>>>>>> 615b25c20 (Rebase attempt number 2)
55935463
[`accept-comment-above-statement`]: https://doc.rust-lang.org/clippy/lint_configuration.html#accept-comment-above-statement
55945464
[`accept-comment-above-attributes`]: https://doc.rust-lang.org/clippy/lint_configuration.html#accept-comment-above-attributes
55955465
[`allow-one-hash-in-raw-strings`]: https://doc.rust-lang.org/clippy/lint_configuration.html#allow-one-hash-in-raw-strings
5596-
<<<<<<< HEAD
5597-
=======
5598-
>>>>>>> d5b2f1134 (Now `cargo collect-metadata` updates the `CHANGELOG.md`)
5599-
=======
5600-
[`accept-comment-above-statement`]: https://doc.rust-lang.org/clippy/lint_configuration.html#accept-comment-above-statement
5601-
>>>>>>> d6102018b (Collecting metadata)
5602-
=======
5603-
>>>>>>> cc2e49f69 (allow safety comment above attributes)
5604-
=======
5605-
[`allow-one-hash-in-raw-string`]: https://doc.rust-lang.org/clippy/lint_configuration.html#allow-one-hash-in-raw-string
5606-
>>>>>>> cb52d19ce (don't lint `needless_raw_string_hashes` when it's unnecessary)
5607-
=======
5608-
[`allow-one-hash-in-raw-strings`]: https://doc.rust-lang.org/clippy/lint_configuration.html#allow-one-hash-in-raw-strings
5609-
>>>>>>> 8cb6c8699 (change category and refactor)
5610-
>>>>>>> 0567691cb (This commit resolves issue #10655)
5611-
=======
5612-
>>>>>>> 615b25c20 (Rebase attempt number 2)
56135466
<!-- end autogenerated links to configuration documentation -->

Cargo.toml

-21
Original file line numberDiff line numberDiff line change
@@ -34,33 +34,12 @@ toml = "0.7.3"
3434
walkdir = "2.3"
3535
# This is used by the `collect-metadata` alias.
3636
filetime = "0.2"
37-
<<<<<<< HEAD
38-
<<<<<<< HEAD
3937
itertools = "0.10.1"
40-
=======
41-
<<<<<<< HEAD
42-
<<<<<<< HEAD
43-
=======
44-
>>>>>>> 0567691cb (This commit resolves issue #10655)
4538

4639
# UI test dependencies
4740
clippy_utils = { path = "clippy_utils" }
4841
derive-new = "0.5"
4942
if_chain = "1.0"
50-
<<<<<<< HEAD
51-
=======
52-
>>>>>>> 066037b62 (actually, remove rustc-workspace-hack dependency too)
53-
=======
54-
>>>>>>> 514b6d04b (Port clippy away from compiletest to ui_test)
55-
=======
56-
>>>>>>> 615b25c20 (Rebase attempt number 2)
57-
itertools = "0.10.1"
58-
59-
# UI test dependencies
60-
clippy_utils = { path = "clippy_utils" }
61-
derive-new = "0.5"
62-
if_chain = "1.0"
63-
>>>>>>> 0567691cb (This commit resolves issue #10655)
6443
quote = "1.0"
6544
serde = { version = "1.0.125", features = ["derive"] }
6645
syn = { version = "2.0", features = ["full"] }

book/src/configuration.md

-25
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,6 @@
22

33
> **Note:** The configuration file is unstable and may be deprecated in the future.
44
5-
<<<<<<< HEAD
6-
<<<<<<< HEAD
7-
=======
8-
<<<<<<< HEAD
9-
<<<<<<< HEAD
10-
=======
11-
>>>>>>> 194343fce (Explain path-search using a list)
12-
>>>>>>> 0567691cb (This commit resolves issue #10655)
13-
=======
14-
>>>>>>> 615b25c20 (Rebase attempt number 2)
155
Some lints can be configured in a TOML file named `clippy.toml` or `.clippy.toml`, which is searched for in:
166

177
1. The directory specified by the `CLIPPY_CONF_DIR` environment variable, or
@@ -20,21 +10,6 @@ Some lints can be configured in a TOML file named `clippy.toml` or `.clippy.toml
2010
3. The current directory.
2111

2212
It contains a basic `variable = value` mapping e.g.
23-
<<<<<<< HEAD
24-
<<<<<<< HEAD
25-
=======
26-
<<<<<<< HEAD
27-
=======
28-
Some lints can be configured in a TOML file named `clippy.toml` or `.clippy.toml`, placed in a directory specified by
29-
the environment variable `CLIPPY_CONF_DIR`, or if that's not found, the environment variable
30-
[CARGO_MANIFEST_DIR](https://doc.rust-lang.org/cargo/reference/environment-variables.html), or if that isn't
31-
found, the current directory. It contains a basic `variable = value` mapping e.g.
32-
>>>>>>> 5f5e2e2ac (Explain which paths clippy searches for configuration in docs)
33-
=======
34-
>>>>>>> 194343fce (Explain path-search using a list)
35-
>>>>>>> 0567691cb (This commit resolves issue #10655)
36-
=======
37-
>>>>>>> 615b25c20 (Rebase attempt number 2)
3813

3914
```toml
4015
avoid-breaking-exported-api = false

book/src/development/adding_lints.md

-25
Original file line numberDiff line numberDiff line change
@@ -627,16 +627,6 @@ Before submitting your PR make sure you followed all the basic requirements:
627627

628628
## Adding configuration to a lint
629629

630-
<<<<<<< HEAD
631-
<<<<<<< HEAD
632-
=======
633-
<<<<<<< HEAD
634-
<<<<<<< HEAD
635-
=======
636-
>>>>>>> 194343fce (Explain path-search using a list)
637-
>>>>>>> 0567691cb (This commit resolves issue #10655)
638-
=======
639-
>>>>>>> 615b25c20 (Rebase attempt number 2)
640630
Clippy supports the configuration of lints values using a `clippy.toml` file which is searched for in:
641631

642632
1. The directory specified by the `CLIPPY_CONF_DIR` environment variable, or
@@ -645,21 +635,6 @@ Clippy supports the configuration of lints values using a `clippy.toml` file whi
645635
3. The current directory.
646636

647637
Adding a configuration to a lint can be useful for
648-
<<<<<<< HEAD
649-
<<<<<<< HEAD
650-
=======
651-
<<<<<<< HEAD
652-
=======
653-
Clippy supports the configuration of lints values using a `clippy.toml` file in a directory specified by
654-
the environment variable `CLIPPY_CONF_DIR`, or if that's not found, the environment variable
655-
[CARGO_MANIFEST_DIR](https://doc.rust-lang.org/cargo/reference/environment-variables.html), or if that isn't
656-
found, the current directory. Adding a configuration to a lint can be useful for
657-
>>>>>>> 5f5e2e2ac (Explain which paths clippy searches for configuration in docs)
658-
=======
659-
>>>>>>> 194343fce (Explain path-search using a list)
660-
>>>>>>> 0567691cb (This commit resolves issue #10655)
661-
=======
662-
>>>>>>> 615b25c20 (Rebase attempt number 2)
663638
thresholds or to constrain some behavior that can be seen as a false positive
664639
for some users. Adding a configuration is done in the following steps:
665640

book/src/development/lint_passes.md

-16
Original file line numberDiff line numberDiff line change
@@ -50,23 +50,7 @@ questions already, but the parser is okay with it. This is what we
5050
mean when we say `EarlyLintPass` deals with only syntax on the AST level.
5151

5252
Alternatively, think of the `foo_functions` lint we mentioned in
53-
<<<<<<< HEAD
54-
<<<<<<< HEAD
5553
define new lints <!-- FIXME: add link --> chapter.
56-
=======
57-
<<<<<<< HEAD
58-
<<<<<<< HEAD
59-
define new lints chapter.
60-
=======
61-
define new lints <!-- FIXME: add link --> chapter.
62-
>>>>>>> d1f55e6b5 (run linkcheck in Remark CI)
63-
=======
64-
define new lints <!-- FIXME: add link --> chapter.
65-
>>>>>>> 7e9abb311 (Merge commit '371120bdbf58a331db5dcfb2d9cddc040f486de8' into clippyup)
66-
>>>>>>> 0567691cb (This commit resolves issue #10655)
67-
=======
68-
define new lints <!-- FIXME: add link --> chapter.
69-
>>>>>>> 615b25c20 (Rebase attempt number 2)
7054

7155
We want the `foo_functions` lint to detect functions with `foo` as their name.
7256
Writing a lint that only checks for the name of a function means that we only

0 commit comments

Comments
 (0)