@@ -3881,6 +3881,13 @@ impl Methods {
3881
3881
unnecessary_lazy_eval:: check ( cx, expr, recv, arg, "and" ) ;
3882
3882
}
3883
3883
} ,
3884
+ ( "any" , [ arg] ) if let ExprKind :: Closure ( arg) = arg. kind
3885
+ && let body = cx. tcx . hir ( ) . body ( arg. body )
3886
+ && let [ param] = body. params
3887
+ && let Some ( ( "chars" , recv, _, _, _) ) = method_call ( recv) =>
3888
+ {
3889
+ string_lit_chars_any:: check ( cx, expr, recv, param, peel_blocks ( body. value ) , & self . msrv ) ;
3890
+ }
3884
3891
( "arg" , [ arg] ) => {
3885
3892
suspicious_command_arg_space:: check ( cx, recv, arg, span) ;
3886
3893
}
@@ -3999,15 +4006,6 @@ impl Methods {
3999
4006
unnecessary_join:: check ( cx, expr, recv, join_arg, span) ;
4000
4007
}
4001
4008
} ,
4002
- ( "skip" , [ arg] ) => {
4003
- iter_skip_zero:: check ( cx, expr, arg) ;
4004
-
4005
- if let Some ( ( name2, recv2, args2, _span2, _) ) = method_call ( recv) {
4006
- if let ( "cloned" , [ ] ) = ( name2, args2) {
4007
- iter_overeager_cloned:: check ( cx, expr, recv, recv2, false , false ) ;
4008
- }
4009
- }
4010
- }
4011
4009
( "last" , [ ] ) => {
4012
4010
if let Some ( ( name2, recv2, args2, _span2, _) ) = method_call ( recv) {
4013
4011
if let ( "cloned" , [ ] ) = ( name2, args2) {
@@ -4060,13 +4058,6 @@ impl Methods {
4060
4058
}
4061
4059
}
4062
4060
} ,
4063
- ( "any" , [ arg] ) if let ExprKind :: Closure ( arg) = arg. kind
4064
- && let body = cx. tcx . hir ( ) . body ( arg. body )
4065
- && let [ param] = body. params
4066
- && let Some ( ( "chars" , recv, _, _, _) ) = method_call ( recv) =>
4067
- {
4068
- string_lit_chars_any:: check ( cx, expr, recv, param, peel_blocks ( body. value ) , & self . msrv ) ;
4069
- }
4070
4061
( "nth" , [ n_arg] ) => match method_call ( recv) {
4071
4062
Some ( ( "bytes" , recv2, [ ] , _, _) ) => bytes_nth:: check ( cx, expr, recv2, n_arg) ,
4072
4063
Some ( ( "cloned" , recv2, [ ] , _, _) ) => iter_overeager_cloned:: check ( cx, expr, recv, recv2, false , false ) ,
@@ -4120,6 +4111,15 @@ impl Methods {
4120
4111
seek_to_start_instead_of_rewind:: check ( cx, expr, recv, arg, span) ;
4121
4112
}
4122
4113
} ,
4114
+ ( "skip" , [ arg] ) => {
4115
+ iter_skip_zero:: check ( cx, expr, arg) ;
4116
+
4117
+ if let Some ( ( name2, recv2, args2, _span2, _) ) = method_call ( recv) {
4118
+ if let ( "cloned" , [ ] ) = ( name2, args2) {
4119
+ iter_overeager_cloned:: check ( cx, expr, recv, recv2, false , false ) ;
4120
+ }
4121
+ }
4122
+ }
4123
4123
( "sort" , [ ] ) => {
4124
4124
stable_sort_primitive:: check ( cx, expr, recv) ;
4125
4125
} ,
@@ -4214,16 +4214,16 @@ impl Methods {
4214
4214
}
4215
4215
unnecessary_literal_unwrap:: check ( cx, expr, recv, name, args) ;
4216
4216
} ,
4217
+ ( "write" , [ ] ) => {
4218
+ readonly_write_lock:: check ( cx, expr, recv) ;
4219
+ }
4217
4220
( "zip" , [ arg] ) => {
4218
4221
if let ExprKind :: MethodCall ( name, iter_recv, [ ] , _) = recv. kind
4219
4222
&& name. ident . name == sym:: iter
4220
4223
{
4221
4224
range_zip_with_len:: check ( cx, expr, iter_recv, arg) ;
4222
4225
}
4223
4226
} ,
4224
- ( "write" , [ ] ) => {
4225
- readonly_write_lock:: check ( cx, expr, recv) ;
4226
- }
4227
4227
_ => { } ,
4228
4228
}
4229
4229
}
0 commit comments