Declare hover_actions_* as local

Author: alibektas

crates/rust-analyzer/src/config.rs

@@ -298,42 +298,6 @@ config_data! {
         files_watcher: FilesWatcherDef = "\"client\"",
 
 
-        /// Whether to show `Debug` action. Only applies when
-        /// `#rust-analyzer.hover.actions.enable#` is set.
-        hover_actions_debug_enable: bool           = "true",
-        /// Whether to show HoverActions in Rust files.
-        hover_actions_enable: bool          = "true",
-        /// Whether to show `Go to Type Definition` action. Only applies when
-        /// `#rust-analyzer.hover.actions.enable#` is set.
-        hover_actions_gotoTypeDef_enable: bool     = "true",
-        /// Whether to show `Implementations` action. Only applies when
-        /// `#rust-analyzer.hover.actions.enable#` is set.
-        hover_actions_implementations_enable: bool = "true",
-        /// Whether to show `References` action. Only applies when
-        /// `#rust-analyzer.hover.actions.enable#` is set.
-        hover_actions_references_enable: bool      = "false",
-        /// Whether to show `Run` action. Only applies when
-        /// `#rust-analyzer.hover.actions.enable#` is set.
-        hover_actions_run_enable: bool             = "true",
-
-        /// Whether to show documentation on hover.
-        hover_documentation_enable: bool           = "true",
-        /// Whether to show keyword hover popups. Only applies when
-        /// `#rust-analyzer.hover.documentation.enable#` is set.
-        hover_documentation_keywords_enable: bool  = "true",
-        /// Use markdown syntax for links on hover.
-        hover_links_enable: bool = "true",
-        /// How to render the align information in a memory layout hover.
-        hover_memoryLayout_alignment: Option<MemoryLayoutHoverRenderKindDef> = "\"hexadecimal\"",
-        /// Whether to show memory layout data on hover.
-        hover_memoryLayout_enable: bool = "true",
-        /// How to render the niche information in a memory layout hover.
-        hover_memoryLayout_niches: Option<bool> = "false",
-        /// How to render the offset information in a memory layout hover.
-        hover_memoryLayout_offset: Option<MemoryLayoutHoverRenderKindDef> = "\"hexadecimal\"",
-        /// How to render the size information in a memory layout hover.
-        hover_memoryLayout_size: Option<MemoryLayoutHoverRenderKindDef> = "\"both\"",
-
         /// Enables the experimental support for interpreting tests.
         interpret_tests: bool                                      = "false",
 
@@ -507,6 +471,42 @@ config_data! {
         /// Enables highlighting of all break points for a loop or block context while the cursor is on any `async` or `await` keywords.
         highlightRelated_yieldPoints_enable: bool = "true",
 
+        /// Whether to show `Debug` action. Only applies when
+        /// `#rust-analyzer.hover.actions.enable#` is set.
+        hover_actions_debug_enable: bool           = "true",
+        /// Whether to show HoverActions in Rust files.
+        hover_actions_enable: bool          = "true",
+        /// Whether to show `Go to Type Definition` action. Only applies when
+        /// `#rust-analyzer.hover.actions.enable#` is set.
+        hover_actions_gotoTypeDef_enable: bool     = "true",
+        /// Whether to show `Implementations` action. Only applies when
+        /// `#rust-analyzer.hover.actions.enable#` is set.
+        hover_actions_implementations_enable: bool = "true",
+        /// Whether to show `References` action. Only applies when
+        /// `#rust-analyzer.hover.actions.enable#` is set.
+        hover_actions_references_enable: bool      = "false",
+        /// Whether to show `Run` action. Only applies when
+        /// `#rust-analyzer.hover.actions.enable#` is set.
+        hover_actions_run_enable: bool             = "true",
+
+        /// Whether to show documentation on hover.
+        hover_documentation_enable: bool           = "true",
+        /// Whether to show keyword hover popups. Only applies when
+        /// `#rust-analyzer.hover.documentation.enable#` is set.
+        hover_documentation_keywords_enable: bool  = "true",
+        /// Use markdown syntax for links on hover.
+        hover_links_enable: bool = "true",
+        /// How to render the align information in a memory layout hover.
+        hover_memoryLayout_alignment: Option<MemoryLayoutHoverRenderKindDef> = "\"hexadecimal\"",
+        /// Whether to show memory layout data on hover.
+        hover_memoryLayout_enable: bool = "true",
+        /// How to render the niche information in a memory layout hover.
+        hover_memoryLayout_niches: Option<bool> = "false",
+        /// How to render the offset information in a memory layout hover.
+        hover_memoryLayout_offset: Option<MemoryLayoutHoverRenderKindDef> = "\"hexadecimal\"",
+        /// How to render the size information in a memory layout hover.
+        hover_memoryLayout_size: Option<MemoryLayoutHoverRenderKindDef> = "\"both\"",
+
         /// Whether to show inlay type hints for binding modes.
         inlayHints_bindingModeHints_enable: bool                   = "false",
         /// Whether to show inlay type hints for method chains.
@@ -743,6 +743,55 @@ impl<'a> LocalConfigView<'a> {
         }
     }
 
+    pub fn hover_actions(&self) -> HoverActionsConfig {
+        let enable = self.experimental("hoverActions") && self.local.hover_actions_enable;
+        HoverActionsConfig {
+            implementations: enable && self.local.hover_actions_implementations_enable,
+            references: enable && self.local.hover_actions_references_enable,
+            run: enable && self.local.hover_actions_run_enable,
+            debug: enable && self.local.hover_actions_debug_enable,
+            goto_type_def: enable && self.local.hover_actions_gotoTypeDef_enable,
+        }
+    }
+
+    pub fn hover(&self) -> HoverConfig {
+        let mem_kind = |kind| match kind {
+            MemoryLayoutHoverRenderKindDef::Both => MemoryLayoutHoverRenderKind::Both,
+            MemoryLayoutHoverRenderKindDef::Decimal => MemoryLayoutHoverRenderKind::Decimal,
+            MemoryLayoutHoverRenderKindDef::Hexadecimal => MemoryLayoutHoverRenderKind::Hexadecimal,
+        };
+        HoverConfig {
+            links_in_hover: self.local.hover_links_enable,
+            memory_layout: self.local.hover_memoryLayout_enable.then_some(
+                MemoryLayoutHoverConfig {
+                    size: self.local.hover_memoryLayout_size.map(mem_kind),
+                    offset: self.local.hover_memoryLayout_offset.map(mem_kind),
+                    alignment: self.local.hover_memoryLayout_alignment.map(mem_kind),
+                    niches: self.local.hover_memoryLayout_niches.unwrap_or_default(),
+                },
+            ),
+            documentation: self.local.hover_documentation_enable,
+            format: {
+                let is_markdown = try_or_def!(self
+                    .caps
+                    .text_document
+                    .as_ref()?
+                    .hover
+                    .as_ref()?
+                    .content_format
+                    .as_ref()?
+                    .as_slice())
+                .contains(&MarkupKind::Markdown);
+                if is_markdown {
+                    HoverDocFormat::Markdown
+                } else {
+                    HoverDocFormat::PlainText
+                }
+            },
+            keywords: self.local.hover_documentation_keywords_enable,
+        }
+    }
+
     pub fn inlay_hints(&self) -> InlayHintsConfig {
         let client_capability_fields = self
             .caps
@@ -1742,19 +1791,6 @@ impl Config {
         }
     }
 
-    pub fn hover_actions(&self) -> HoverActionsConfig {
-        let enable =
-            self.experimental("hoverActions") && self.root_config.global.0.hover_actions_enable;
-        HoverActionsConfig {
-            implementations: enable
-                && self.root_config.global.0.hover_actions_implementations_enable,
-            references: enable && self.root_config.global.0.hover_actions_references_enable,
-            run: enable && self.root_config.global.0.hover_actions_run_enable,
-            debug: enable && self.root_config.global.0.hover_actions_debug_enable,
-            goto_type_def: enable && self.root_config.global.0.hover_actions_gotoTypeDef_enable,
-        }
-    }
-
     pub fn highlighting_non_standard_tokens(&self) -> bool {
         self.root_config.global.0.semanticHighlighting_nonStandardTokens
     }
@@ -1788,44 +1824,6 @@ impl Config {
         }
     }
 
-    pub fn hover(&self) -> HoverConfig {
-        let mem_kind = |kind| match kind {
-            MemoryLayoutHoverRenderKindDef::Both => MemoryLayoutHoverRenderKind::Both,
-            MemoryLayoutHoverRenderKindDef::Decimal => MemoryLayoutHoverRenderKind::Decimal,
-            MemoryLayoutHoverRenderKindDef::Hexadecimal => MemoryLayoutHoverRenderKind::Hexadecimal,
-        };
-        HoverConfig {
-            links_in_hover: self.root_config.global.0.hover_links_enable,
-            memory_layout: self.root_config.global.0.hover_memoryLayout_enable.then_some(
-                MemoryLayoutHoverConfig {
-                    size: self.root_config.global.0.hover_memoryLayout_size.map(mem_kind),
-                    offset: self.root_config.global.0.hover_memoryLayout_offset.map(mem_kind),
-                    alignment: self.root_config.global.0.hover_memoryLayout_alignment.map(mem_kind),
-                    niches: self.root_config.global.0.hover_memoryLayout_niches.unwrap_or_default(),
-                },
-            ),
-            documentation: self.root_config.global.0.hover_documentation_enable,
-            format: {
-                let is_markdown = try_or_def!(self
-                    .caps
-                    .text_document
-                    .as_ref()?
-                    .hover
-                    .as_ref()?
-                    .content_format
-                    .as_ref()?
-                    .as_slice())
-                .contains(&MarkupKind::Markdown);
-                if is_markdown {
-                    HoverDocFormat::Markdown
-                } else {
-                    HoverDocFormat::PlainText
-                }
-            },
-            keywords: self.root_config.global.0.hover_documentation_keywords_enable,
-        }
-    }
-
     pub fn workspace_symbol(&self) -> WorkspaceSymbolConfig {
         WorkspaceSymbolConfig {
             search_scope: match self.root_config.global.0.workspace_symbol_search_scope {

crates/rust-analyzer/src/handlers/request.rs

@@ -974,16 +974,17 @@ pub(crate) fn handle_hover(
         PositionOrRange::Position(position) => Range::new(position, position),
         PositionOrRange::Range(range) => range,
     };
-
     let file_range = from_proto::file_range(&snap, &params.text_document, range)?;
-    let info = match snap.analysis.hover(&snap.config.hover(), file_range)? {
+    let local_conf = snap.config.localize_by_file_id(file_range.file_id);
+    let hover = local_conf.hover();
+    let info = match snap.analysis.hover(&hover, file_range)? {
         None => return Ok(None),
         Some(info) => info,
     };
 
     let line_index = snap.file_line_index(file_range.file_id)?;
     let range = to_proto::range(&line_index, info.range);
-    let markup_kind = snap.config.hover().format;
+    let markup_kind = hover.format;
     let hover = lsp_ext::Hover {
         hover: lsp_types::Hover {
             contents: HoverContents::Markup(to_proto::markup_content(
@@ -992,7 +993,7 @@ pub(crate) fn handle_hover(
             )),
             range: Some(range),
         },
-        actions: if snap.config.hover_actions().none() {
+        actions: if local_conf.hover_actions().none() {
             Vec::new()
         } else {
             prepare_hover_actions(&snap, &info.info.actions)
@@ -1795,7 +1796,9 @@ fn show_impl_command_link(
     snap: &GlobalStateSnapshot,
     position: &FilePosition,
 ) -> Option<lsp_ext::CommandLinkGroup> {
-    if snap.config.hover_actions().implementations && snap.config.client_commands().show_reference {
+    if snap.config.localize_by_file_id(position.file_id).hover_actions().implementations
+        && snap.config.client_commands().show_reference
+    {
         if let Some(nav_data) = snap.analysis.goto_implementation(*position).unwrap_or(None) {
             let uri = to_proto::url(snap, position.file_id);
             let line_index = snap.file_line_index(position.file_id).ok()?;
@@ -1821,7 +1824,9 @@ fn show_ref_command_link(
     snap: &GlobalStateSnapshot,
     position: &FilePosition,
 ) -> Option<lsp_ext::CommandLinkGroup> {
-    if snap.config.hover_actions().references && snap.config.client_commands().show_reference {
+    if snap.config.localize_by_file_id(position.file_id).hover_actions().references
+        && snap.config.client_commands().show_reference
+    {
         if let Some(ref_search_res) = snap.analysis.find_all_refs(*position, None).unwrap_or(None) {
             let uri = to_proto::url(snap, position.file_id);
             let line_index = snap.file_line_index(position.file_id).ok()?;
@@ -1851,12 +1856,14 @@ fn runnable_action_links(
     snap: &GlobalStateSnapshot,
     runnable: Runnable,
 ) -> Option<lsp_ext::CommandLinkGroup> {
-    let hover_actions_config = snap.config.hover_actions();
+    let cargo_spec = CargoTargetSpec::for_file(snap, runnable.nav.file_id).ok()?;
+
+    let hover_actions_config =
+        snap.config.localize_by_file_id(runnable.nav.file_id).hover_actions();
     if !hover_actions_config.runnable() {
         return None;
     }
 
-    let cargo_spec = CargoTargetSpec::for_file(snap, runnable.nav.file_id).ok()?;
     if should_skip_target(&runnable, cargo_spec.as_ref()) {
         return None;
     }
@@ -1888,8 +1895,12 @@ fn goto_type_action_links(
     snap: &GlobalStateSnapshot,
     nav_targets: &[HoverGotoTypeData],
 ) -> Option<lsp_ext::CommandLinkGroup> {
-    if !snap.config.hover_actions().goto_type_def
-        || nav_targets.is_empty()
+    if nav_targets.is_empty()
+        || !snap
+            .config
+            .localize_by_file_id(nav_targets[0].nav.file_id)
+            .hover_actions()
+            .goto_type_def
         || !snap.config.client_commands().goto_location
     {
         return None;