docs: 0344-conventions-galore.md should use _
#3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamirmahal
commented
Apr 30, 2024
| @@ -213,7 +213,7 @@ seem like a minor concern, when we hit 1.0 the lint names will be locked down, | |||
| so it's worth trying to clean them up now. | |||
|
|
|||
| The basic rule is: the lint name should make sense when read as "allow | |||
| *lint-name*" or "allow *lint-name* items". For example, "allow | |||
| *lint_name*" or "allow *lint_name* items". For example, "allow | |||
There was a problem hiding this comment.
These are just inline examples, but they should follow the _ convention given in the rest of this section.
ehuss
added
the
not-rfc
|
@fmease are you open to this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3618.
Rendered