Skip to content

Updating links for accepted RFCs #2183

Closed
@ExpHP

Description

@ExpHP

The hardest time to locate the text of an RFC is after it gets merged.

Here's what happens:

  • The rendered markdown link in the top post invariably points to the author's fork, because that's where the file originally existed.
  • RFC gets merged.
  • A tracking issue gets created which invariably contains a link to the pull request, but no link to the rendered text.
  • Github presents the author with a shiny button to delete their useless branch.
  • Author clicks the button. 🍹 Ahhh, refreshing.
  • Rendered link is now broken.

Not having found myself on the other side of the "merge" coin all too often, I'm not certain, do the repo maintainers have the ability to edit the PR text and fix the link when they merge? Can this be part of the process?

(Or alternatively, make it a point to put these links in tracking issues?)

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-coreRelevant to the core team, which will review and decide on the RFC.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions