Skip to content

FCPs proposed by the addition of labels to an issue with a previously-ignored command #286

Open
@anp

Description

@anp

An example:

  1. @nikomatsakis asks for a merge in illumos toolchain builds compiler-team#279 (comment)
  2. rfcbot ignores because no T-* labels
  3. @nikomatsakis adds T-compiler in illumos toolchain builds compiler-team#279 (comment)
  4. rfcbot continues to do nothing, presumably because we only check if a comment is an fcp start when the comment changes, not the issue?
  5. @nikomatsakis invokes again in illumos toolchain builds compiler-team#279 (comment) and it works

Ideally, rfcbot could detect the state change in (3) as representing a proposal. I'm not sure it's a good idea to do that without also making sure that modifying team labels mid-FCP works correctly. If that's not feasible, it would at least be good for rfcbot to post a comment when (3) happens.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions