Skip to content

We're computing mangle_internal_symbol a lot #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RalfJung opened this issue Mar 20, 2025 · 0 comments · Fixed by #4241
Closed

We're computing mangle_internal_symbol a lot #4234

RalfJung opened this issue Mar 20, 2025 · 0 comments · Fixed by #4241

Comments

@RalfJung
Copy link
Member

RalfJung commented Mar 20, 2025 •
edited
Loading

Each time a shim is called, we're calling mangle_internal_symbol a half-dozen times to check if that is one of the allocator shims. We should memoize those mangled symbols somewhere.

This was introduced in rust-lang/rust#127173. Cc @bjorn3
@RalfJung RalfJung changed the title W're computing mangle_internal_symbol a lot We're computing mangle_internal_symbol a lot Mar 20, 2025
@RalfJung RalfJung mentioned this issue Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cache mangle_internal_symbol results RalfJung/miri
1 participant
@RalfJung