Skip to content

Conflicting name attributes on searchbar input #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dtolnay opened this issue Nov 13, 2020 · 1 comment
Closed

Conflicting name attributes on searchbar input #1382

dtolnay opened this issue Nov 13, 2020 · 1 comment

Comments

@dtolnay
Copy link
Member

dtolnay commented Nov 13, 2020

This <input> has both name="search" and name="searchbar". I'm not sure how browsers handle this but it's confusing at best, and seems unintentional. It would be better to have just one (not sure which is the right one).

mdBook/src/theme/index.hbs

Line 157 in 59f2a9b

<input type="search" name="search" id="searchbar" name="searchbar" placeholder="Search this book ..." aria-controls="searchresults-outer" aria-describedby="searchresults-header">

@ehuss
Copy link
Contributor

ehuss commented Jul 27, 2021

This was fixed in #1509.

@ehuss ehuss closed this as completed Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ehuss @dtolnay