Skip to content

Commit b86d2d6

Browse files
lvllvllvllvl
committed
chore: add labels to FIXMEs
1 parent 4bc5300 commit b86d2d6

File tree

23 files changed

+89
-85
lines changed

23 files changed

+89
-85
lines changed

‎libc-test/build.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2081,6 +2081,9 @@ fn test_android(target: &str) {
20812081
// Added in API level 26, but some tests use level 24.
20822082
"endgrent" => true,
20832083

2084+
// Added in API level 26, but some tests use level 24.
2085+
"getdomainname" | "setdomainname" => true,
2086+
20842087
// FIXME: bad function pointers:
20852088
"isalnum" | "isalpha" | "iscntrl" | "isdigit" | "isgraph" | "islower" | "isprint"
20862089
| "ispunct" | "isspace" | "isupper" | "isxdigit" | "isblank" | "tolower"

‎libc-test/semver/android.txt‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3324,6 +3324,7 @@ getaddrinfo
33243324
getchar
33253325
getchar_unlocked
33263326
getcwd
3327+
getdomainname
33273328
getegid
33283329
getenv
33293330
geteuid
@@ -3720,6 +3721,7 @@ sendmsg
37203721
sendto
37213722
servent
37223723
setbuf
3724+
setdomainname
37233725
setegid
37243726
setenv
37253727
seteuid

‎src/unix/hurd/mod.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ pub type nl_item = c_int;
226226
pub type iconv_t = *mut c_void;
227227

228228
#[cfg_attr(feature = "extra_traits", derive(Debug))]
229-
pub enum fpos64_t {} // FIXME: fill this out with a struct
229+
pub enum fpos64_t {} // FIXME(hurd): fill this out with a struct
230230
impl Copy for fpos64_t {}
231231
impl Clone for fpos64_t {
232232
fn clone(&self) -> fpos64_t {
@@ -814,7 +814,7 @@ s! {
814814
pub ifa_flags: c_uint,
815815
pub ifa_addr: *mut crate::sockaddr,
816816
pub ifa_netmask: *mut crate::sockaddr,
817-
pub ifa_ifu: *mut crate::sockaddr, // FIXME This should be a union
817+
pub ifa_ifu: *mut crate::sockaddr, // FIXME(union) This should be a union
818818
pub ifa_data: *mut c_void,
819819
}
820820

@@ -1092,7 +1092,7 @@ cfg_if! {
10921092
.field("ut_line", &self.ut_line)
10931093
.field("ut_id", &self.ut_id)
10941094
.field("ut_user", &self.ut_user)
1095-
// FIXME: .field("ut_host", &self.ut_host)
1095+
// FIXME(debug): .field("ut_host", &self.ut_host)
10961096
.field("ut_exit", &self.ut_exit)
10971097
.field("ut_session", &self.ut_session)
10981098
.field("ut_tv", &self.ut_tv)

‎src/unix/linux_like/android/b32/x86/mod.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -281,11 +281,11 @@ pub const SYS_personality: c_long = 136;
281281
pub const SYS_afs_syscall: c_long = 137;
282282
pub const SYS_setfsuid: c_long = 138;
283283
pub const SYS_setfsgid: c_long = 139;
284-
// FIXME: SYS__llseek is in the NDK sources but for some reason is
284+
// FIXME(android): SYS__llseek is in the NDK sources but for some reason is
285285
// not available in the tests
286286
// pub const SYS__llseek: c_long = 140;
287287
pub const SYS_getdents: c_long = 141;
288-
// FIXME: SYS__newselect is in the NDK sources but for some reason is
288+
// FIXME(android): SYS__newselect is in the NDK sources but for some reason is
289289
// not available in the tests
290290
// pub const SYS__newselect: c_long = 142;
291291
pub const SYS_flock: c_long = 143;
@@ -294,7 +294,7 @@ pub const SYS_readv: c_long = 145;
294294
pub const SYS_writev: c_long = 146;
295295
pub const SYS_getsid: c_long = 147;
296296
pub const SYS_fdatasync: c_long = 148;
297-
// FIXME: SYS__llseek is in the NDK sources but for some reason is
297+
// FIXME(android): SYS__llseek is in the NDK sources but for some reason is
298298
// not available in the tests
299299
// pub const SYS__sysctl: c_long = 149;
300300
pub const SYS_mlock: c_long = 150;

‎src/unix/linux_like/android/b64/mod.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ cfg_if! {
161161
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
162162
f.debug_struct("pthread_mutex_t")
163163
.field("value", &self.value)
164-
// FIXME: .field("__reserved", &self.__reserved)
164+
// FIXME(debug): .field("__reserved", &self.__reserved)
165165
.finish()
166166
}
167167
}
@@ -190,7 +190,7 @@ cfg_if! {
190190
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
191191
f.debug_struct("pthread_cond_t")
192192
.field("value", &self.value)
193-
// FIXME: .field("__reserved", &self.__reserved)
193+
// FIXME(debug): .field("__reserved", &self.__reserved)
194194
.finish()
195195
}
196196
}
@@ -227,7 +227,7 @@ cfg_if! {
227227
.field("pendingReaders", &self.pendingReaders)
228228
.field("pendingWriters", &self.pendingWriters)
229229
.field("attr", &self.attr)
230-
// FIXME: .field("__reserved", &self.__reserved)
230+
// FIXME(debug): .field("__reserved", &self.__reserved)
231231
.finish()
232232
}
233233
}

‎src/unix/linux_like/android/b64/x86_64/mod.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ cfg_if! {
353353
.field("mxcsr", &self.mxcsr)
354354
.field("mxcr_mask", &self.mxcr_mask)
355355
.field("st_space", &self.st_space)
356-
// FIXME: .field("xmm_space", &self.xmm_space)
356+
// FIXME(debug): .field("xmm_space", &self.xmm_space)
357357
// Ignore padding field
358358
.finish()
359359
}
@@ -545,7 +545,7 @@ pub const SYS_munlockall: c_long = 152;
545545
pub const SYS_vhangup: c_long = 153;
546546
pub const SYS_modify_ldt: c_long = 154;
547547
pub const SYS_pivot_root: c_long = 155;
548-
// FIXME: SYS__sysctl is in the NDK sources but for some reason is
548+
// FIXME(android): SYS__sysctl is in the NDK sources but for some reason is
549549
// not available in the tests
550550
// pub const SYS__sysctl: c_long = 156;
551551
pub const SYS_prctl: c_long = 157;

‎src/unix/linux_like/android/mod.rs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,7 @@ cfg_if! {
690690
.field("d_off", &self.d_off)
691691
.field("d_reclen", &self.d_reclen)
692692
.field("d_type", &self.d_type)
693-
// FIXME: .field("d_name", &self.d_name)
693+
// FIXME(debug): .field("d_name", &self.d_name)
694694
.finish()
695695
}
696696
}
@@ -728,7 +728,7 @@ cfg_if! {
728728
.field("d_off", &self.d_off)
729729
.field("d_reclen", &self.d_reclen)
730730
.field("d_type", &self.d_type)
731-
// FIXME: .field("d_name", &self.d_name)
731+
// FIXME(debug): .field("d_name", &self.d_name)
732732
.finish()
733733
}
734734
}
@@ -800,7 +800,7 @@ cfg_if! {
800800
f.debug_struct("lastlog")
801801
.field("ll_time", &self.ll_time)
802802
.field("ll_line", &self.ll_line)
803-
// FIXME: .field("ll_host", &self.ll_host)
803+
// FIXME(debug): .field("ll_host", &self.ll_host)
804804
.finish()
805805
}
806806
}
@@ -851,7 +851,7 @@ cfg_if! {
851851
.field("ut_line", &self.ut_line)
852852
.field("ut_id", &self.ut_id)
853853
.field("ut_user", &self.ut_user)
854-
// FIXME: .field("ut_host", &self.ut_host)
854+
// FIXME(debug): .field("ut_host", &self.ut_host)
855855
.field("ut_exit", &self.ut_exit)
856856
.field("ut_session", &self.ut_session)
857857
.field("ut_tv", &self.ut_tv)

‎src/unix/linux_like/emscripten/mod.rs‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ pub type statvfs64 = crate::statvfs;
4444
pub type dirent64 = crate::dirent;
4545

4646
#[cfg_attr(feature = "extra_traits", derive(Debug))]
47-
pub enum fpos64_t {} // FIXME: fill this out with a struct
47+
pub enum fpos64_t {} // FIXME(emscripten): fill this out with a struct
4848
impl Copy for fpos64_t {}
4949
impl Clone for fpos64_t {
5050
fn clone(&self) -> fpos64_t {
@@ -412,7 +412,7 @@ cfg_if! {
412412
.field("d_off", &self.d_off)
413413
.field("d_reclen", &self.d_reclen)
414414
.field("d_type", &self.d_type)
415-
// FIXME: .field("d_name", &self.d_name)
415+
// FIXME(debug): .field("d_name", &self.d_name)
416416
.finish()
417417
}
418418
}
@@ -465,7 +465,7 @@ cfg_if! {
465465
.field("totalhigh", &self.totalhigh)
466466
.field("freehigh", &self.freehigh)
467467
.field("mem_unit", &self.mem_unit)
468-
// FIXME: .field("__reserved", &self.__reserved)
468+
// FIXME(debug): .field("__reserved", &self.__reserved)
469469
.finish()
470470
}
471471
}
@@ -525,7 +525,7 @@ cfg_if! {
525525
impl fmt::Debug for pthread_cond_t {
526526
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
527527
f.debug_struct("pthread_cond_t")
528-
// FIXME: .field("size", &self.size)
528+
// FIXME(debug): .field("size", &self.size)
529529
.finish()
530530
}
531531
}
@@ -1576,8 +1576,6 @@ extern "C" {
15761576
pub fn mkstemps(template: *mut c_char, suffixlen: c_int) -> c_int;
15771577
pub fn nl_langinfo(item: crate::nl_item) -> *mut c_char;
15781578

1579-
pub fn getdomainname(name: *mut c_char, len: size_t) -> c_int;
1580-
pub fn setdomainname(name: *const c_char, len: size_t) -> c_int;
15811579
pub fn sendmmsg(
15821580
sockfd: c_int,
15831581
msgvec: *mut crate::mmsghdr,

‎src/unix/linux_like/linux/gnu/b64/aarch64/mod.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ pub const HWCAP_SSBS: c_ulong = 1 << 28;
601601
pub const HWCAP_SB: c_ulong = 1 << 29;
602602
pub const HWCAP_PACA: c_ulong = 1 << 30;
603603
pub const HWCAP_PACG: c_ulong = 1 << 31;
604-
// FIXME: enable these again once linux-api-headers are up to date enough on CI.
604+
// FIXME(linux): enable these again once linux-api-headers are up to date enough on CI.
605605
// See discussion in https://github.com/rust-lang/libc/pull/1638
606606
//pub const HWCAP2_DCPODP: c_ulong = 1 << 0;
607607
//pub const HWCAP2_SVE2: c_ulong = 1 << 1;

‎src/unix/linux_like/linux/gnu/b64/s390x.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ s! {
212212
}
213213

214214
s_no_extra_traits! {
215-
// FIXME: This is actually a union.
215+
// FIXME(union): This is actually a union.
216216
pub struct fpreg_t {
217217
pub d: c_double,
218218
// f: c_float,

0 commit comments

Comments
 (0)