-
Notifications
You must be signed in to change notification settings - Fork 639
Missing packages should return HTTP 404 #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
It is responding 404:
|
@onur It seems to be dependent on the
|
jtgeibel
added a commit
to jtgeibel/crates.io
that referenced
this issue
Jul 25, 2019
The backend no longer checks for an "html" in the `Accept` header. With the exception of 3 session related routes, all paths not starting with "/api" will be redirected to the static Ember bootstrap page. As a result of this change all non-api requests that don't contain "html" in the `Accept` header will now unconditionally return `200`, rather than `404`. In a sense, this expands the scope of rust-lang#556 to all requests, not just those that set the header. It also inverts the problem described in rust-lang#788, effectively turning it into a duplicate of rust-lang#556. Fixes: rust-lang#163
Closing as a duplicate of #788. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If
https://crates.io/crates/nonexistent_package
does not refer to a valid package, it should respond with HTTP 404 to avoid misleading crawlers and/or browsers into thinking that it's a valid page.The text was updated successfully, but these errors were encountered: