Skip to content

use separate build directory for rust-analyzer to use #889

Closed
@tshepang

Description

@tshepang

Proposal

To avoid the issue of locking between normal builds and rust-analyzer builds, we should set the in-tree rust-analyzer settings (accessible via x setup editor) to make rust-analyzer use a build directory separate from the one used by bootstrap.

In addition to that, it would be good to decide on the following 2 options:

  • Use build/rust-analyzer/ (currently used by Helix settings)

    The benefit is that we don't have to add another top-level directory.

  • Use build-rust-analyzer/

    The benefit is that x clean --all does not also remove rust-analyzer build artefacts
    (because "build/" belongs to bootstrap, probably).

    make rust-analyzer use a dedicated build directory rust#141839 follows this approach.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedto-announceAnnounce this issue on triage meeting

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions