Skip to content

Commit 11bcc2b

Browse files
committed
refactor(toml): Pull out schema
Remaining steps - Decouple `toml/mod.rs` functionality from `toml/schema.rs` - Pull out `core/` types referenced by `toml/schema.rs`
1 parent a96de8a commit 11bcc2b

File tree

13 files changed

+1296
-1259
lines changed

13 files changed

+1296
-1259
lines changed

src/bin/cargo/main.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use cargo::util::network::http::http_handle;
66
use cargo::util::network::http::needs_custom_http_transport;
7-
use cargo::util::toml::StringOrVec;
7+
use cargo::util::toml::schema::StringOrVec;
88
use cargo::util::CliError;
99
use cargo::util::{self, closest_msg, command_prelude, CargoResult, CliResult, Config};
1010
use cargo_util::{ProcessBuilder, ProcessError};

src/cargo/core/compiler/mod.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ use crate::core::{Feature, PackageId, Target, Verbosity};
9393
use crate::util::errors::{CargoResult, VerboseError};
9494
use crate::util::interning::InternedString;
9595
use crate::util::machine_message::{self, Message};
96-
use crate::util::toml::TomlDebugInfo;
97-
use crate::util::toml::TomlTrimPaths;
96+
use crate::util::toml::schema::TomlDebugInfo;
97+
use crate::util::toml::schema::TomlTrimPaths;
9898
use crate::util::{add_path_args, internal, iter_join_onto, profile};
9999
use cargo_util::{paths, ProcessBuilder, ProcessError};
100100
use rustfix::diagnostics::Applicability;

src/cargo/core/manifest.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ use crate::core::{Dependency, PackageId, PackageIdSpec, SourceId, Summary};
1818
use crate::core::{Edition, Feature, Features, WorkspaceConfig};
1919
use crate::util::errors::*;
2020
use crate::util::interning::InternedString;
21-
use crate::util::toml::{TomlManifest, TomlProfiles};
21+
use crate::util::toml::schema::{TomlManifest, TomlProfiles};
2222
use crate::util::{short_hash, Config, Filesystem, RustVersion};
2323

2424
pub enum EitherManifest {

src/cargo/core/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ pub use self::workspace::{
1414
find_workspace_root, resolve_relative_path, MaybePackage, Workspace, WorkspaceConfig,
1515
WorkspaceRootConfig,
1616
};
17-
pub use crate::util::toml::InheritableFields;
17+
pub use crate::util::toml::schema::InheritableFields;
1818

1919
pub mod compiler;
2020
pub mod dependency;

src/cargo/core/profiles.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ use crate::core::resolver::features::FeaturesFor;
2727
use crate::core::Feature;
2828
use crate::core::{PackageId, PackageIdSpec, Resolve, Shell, Target, Workspace};
2929
use crate::util::interning::InternedString;
30-
use crate::util::toml::TomlTrimPaths;
31-
use crate::util::toml::TomlTrimPathsValue;
32-
use crate::util::toml::{
30+
use crate::util::toml::schema::TomlTrimPaths;
31+
use crate::util::toml::schema::TomlTrimPathsValue;
32+
use crate::util::toml::schema::{
3333
ProfilePackageSpec, StringOrBool, TomlDebugInfo, TomlProfile, TomlProfiles,
3434
};
3535
use crate::util::{closest_msg, config, CargoResult, Config};

src/cargo/core/workspace.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ use crate::sources::{PathSource, CRATES_IO_INDEX, CRATES_IO_REGISTRY};
2222
use crate::util::edit_distance;
2323
use crate::util::errors::{CargoResult, ManifestError};
2424
use crate::util::interning::InternedString;
25-
use crate::util::toml::{read_manifest, InheritableFields, TomlDependency, TomlProfiles};
25+
use crate::util::toml::{
26+
read_manifest, schema::InheritableFields, schema::TomlDependency, schema::TomlProfiles,
27+
};
2628
use crate::util::RustVersion;
2729
use crate::util::{config::ConfigRelativePath, Config, Filesystem, IntoUrl};
2830
use cargo_util::paths;

src/cargo/ops/cargo_package.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ use crate::sources::PathSource;
1616
use crate::util::cache_lock::CacheLockMode;
1717
use crate::util::config::JobsConfig;
1818
use crate::util::errors::CargoResult;
19-
use crate::util::toml::TomlManifest;
19+
use crate::util::toml::schema::TomlManifest;
2020
use crate::util::{self, human_readable_bytes, restricted_names, Config, FileLock};
2121
use crate::{drop_println, ops};
2222
use anyhow::Context as _;

src/cargo/util/command_prelude.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use crate::util::important_paths::find_root_manifest_for_wd;
77
use crate::util::interning::InternedString;
88
use crate::util::is_rustup;
99
use crate::util::restricted_names::is_glob_pattern;
10-
use crate::util::toml::{StringOrVec, TomlProfile};
10+
use crate::util::toml::schema::{StringOrVec, TomlProfile};
1111
use crate::util::validate_package_name;
1212
use crate::util::{
1313
print_available_benches, print_available_binaries, print_available_examples,

0 commit comments

Comments
 (0)