Skip to content

Commit

Permalink
Rollup merge of rust-lang#136567 - adetaylor:test-for-recursion, r=ol…
Browse files Browse the repository at this point in the history
…i-obk

Arbitrary self types v2: recursion test

Add a test for infinite recursion of an arbitrary self type.

These diagnostics aren't perfect (especially the repetition of the statement that there's too much recursion) but for now at least let's add a test to confirm that such diagnostics are emitted.

As suggested by ```@oli-obk```

Relates to rust-lang#44874

r? ```@wesleywiser```
  • Loading branch information
jieyouxu authored Feb 5, 2025
2 parents fd4623b + 0772400 commit eeef079
Show file tree
Hide file tree
Showing 2 changed files with 71 additions and 0 deletions.
24 changes: 24 additions & 0 deletions tests/ui/self/arbitrary_self_type_infinite_recursion.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#![feature(arbitrary_self_types)]

struct MySmartPtr<T>(T);

impl<T> core::ops::Receiver for MySmartPtr<T> {
type Target = MySmartPtr<T>;
}

struct Content;

impl Content {
fn method(self: MySmartPtr<Self>) { // note self type
//~^ reached the recursion limit
//~| reached the recursion limit
//~| invalid `self` parameter type
}
}

fn main() {
let p = MySmartPtr(Content);
p.method();
//~^ reached the recursion limit
//~| no method named `method`
}
47 changes: 47 additions & 0 deletions tests/ui/self/arbitrary_self_type_infinite_recursion.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
error[E0055]: reached the recursion limit while auto-dereferencing `MySmartPtr<Content>`
--> $DIR/arbitrary_self_type_infinite_recursion.rs:12:19
|
LL | fn method(self: MySmartPtr<Self>) { // note self type
| ^^^^^^^^^^^^^^^^ deref recursion limit reached
|
= help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`arbitrary_self_type_infinite_recursion`)

error[E0055]: reached the recursion limit while auto-dereferencing `MySmartPtr<Content>`
--> $DIR/arbitrary_self_type_infinite_recursion.rs:12:19
|
LL | fn method(self: MySmartPtr<Self>) { // note self type
| ^^^^^^^^^^^^^^^^ deref recursion limit reached
|
= help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`arbitrary_self_type_infinite_recursion`)
= note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`

error[E0307]: invalid `self` parameter type: `MySmartPtr<Content>`
--> $DIR/arbitrary_self_type_infinite_recursion.rs:12:19
|
LL | fn method(self: MySmartPtr<Self>) { // note self type
| ^^^^^^^^^^^^^^^^
|
= note: type of `self` must be `Self` or some type implementing `Receiver`
= help: consider changing to `self`, `&self`, `&mut self`, or a type implementing `Receiver` such as `self: Box<Self>`, `self: Rc<Self>`, or `self: Arc<Self>`

error[E0055]: reached the recursion limit while auto-dereferencing `MySmartPtr<Content>`
--> $DIR/arbitrary_self_type_infinite_recursion.rs:21:5
|
LL | p.method();
| ^^^^^^ deref recursion limit reached
|
= help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`arbitrary_self_type_infinite_recursion`)

error[E0599]: no method named `method` found for struct `MySmartPtr` in the current scope
--> $DIR/arbitrary_self_type_infinite_recursion.rs:21:5
|
LL | struct MySmartPtr<T>(T);
| -------------------- method `method` not found for this struct
...
LL | p.method();
| ^^^^^^ method not found in `MySmartPtr<Content>`

error: aborting due to 5 previous errors

Some errors have detailed explanations: E0055, E0307, E0599.
For more information about an error, try `rustc --explain E0055`.

0 comments on commit eeef079

Please sign in to comment.