Skip to content

Commit c332402

Browse files
committedFeb 18, 2025
Merge #20: ci: Build and test with all features
e5102f4 ci: Build and test with all features (Tobin C. Harding) Pull request description: We test various combinations of features in the feature matrix but somehow we forgot to build and test with `--all-features`. We do lint with all features so this is not a massive fail but its a fail none the less. Discovered by Andrew's CI while reviewing recent changes to `corepc`. ACKs for top commit: apoelstra: ACK e5102f4 Tree-SHA512: 13939d370d5d1fac58ab7da6424e0cb316e53f0cd920cde10f0f53152c71fab1dd6429a4efb0a3272de7211d684a9f093e80cc7934fd0a0fd450862c770650ef
2 parents f59bcc8 + e5102f4 commit c332402

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed
 

‎ci/run_task.sh

+3
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,9 @@ do_feature_matrix() {
184184
$cargo test --no-default-features
185185
fi
186186

187+
$cargo build --all-features
188+
$cargo test --all-features
189+
187190
if [ -n "${FEATURES_WITH_STD}" ]; then
188191
loop_features "std" "${FEATURES_WITH_STD}"
189192
fi

0 commit comments

Comments
 (0)
Please sign in to comment.