Remove urlencoding feature

There is no longer a dependency on the urlencoding crate.

Remove the feature and all related feature gates and comments.

Author: jamillambert

bitreq/Cargo.toml

@@ -51,7 +51,6 @@ json-using-serde = ["serde", "serde_json"]
 proxy = ["base64", "std"]
 async = ["tokio", "std"]
 async-https = ["async", "https-rustls", "tokio-rustls"]
-urlencoding = []
 
 [[example]]
 name = "hello"

bitreq/src/http_url.rs

@@ -96,9 +96,6 @@ impl HttpUrl {
                     path_and_query = Some(resource);
                     resource = String::new();
                 }
-                #[cfg(not(feature = "urlencoding"))]
-                UrlParseStatus::PathAndQuery | UrlParseStatus::Fragment => resource.push(c),
-                #[cfg(feature = "urlencoding")]
                 UrlParseStatus::PathAndQuery | UrlParseStatus::Fragment => match c {
                     // All URL-'safe' characters, plus URL 'special
                     // characters' like &, #, =, / ,?
@@ -175,15 +172,13 @@ impl HttpUrl {
 }
 
 /// Returns the `%HH` triplet representing `byte` for percent encoding.
-#[cfg(feature = "urlencoding")]
 fn percent_encoded_triplet(byte: u8) -> [char; 3] {
     const HEX: &[u8; 16] = b"0123456789ABCDEF";
     ['%', HEX[(byte >> 4) as usize] as char, HEX[(byte & 0x0F) as usize] as char]
 }
 
 /// Percent-encodes a char and appends it to `result`.
 /// Unreserved characters (0-9, A-Z, a-z, -, ., _, ~) are not encoded.
-#[cfg(feature = "urlencoding")]
 pub(crate) fn percent_encode_char(c: char, result: &mut String) {
     match c {
         // All URL-'safe' characters are not encoded
@@ -203,7 +198,6 @@ pub(crate) fn percent_encode_char(c: char, result: &mut String) {
 }
 
 /// Percent-encodes the entire input string and returns the encoded version.
-#[cfg(feature = "urlencoding")]
 pub(crate) fn percent_encode_string(input: &str) -> String {
     let mut encoded = String::with_capacity(input.len());
     for ch in input.chars() {

bitreq/src/lib.rs

@@ -72,12 +72,6 @@
 //!
 //! This feature enables HTTP proxy support. See [Proxy].
 //!
-//! ## `urlencoding`
-//!
-//! This feature enables percent-encoding for the URL resource when
-//! creating a request and any subsequently added parameters from
-//! [`Request::with_param`].
-//!
 //! # Examples
 //!
 //! ## Get

bitreq/src/request.rs

@@ -7,7 +7,6 @@ use core::fmt::Write;
 use crate::connection::AsyncConnection;
 #[cfg(feature = "std")]
 use crate::connection::Connection;
-#[cfg(feature = "urlencoding")]
 use crate::http_url::percent_encode_string;
 #[cfg(feature = "std")]
 use crate::http_url::{HttpUrl, Port};
@@ -100,12 +99,8 @@ impl Request {
     /// This is only the request's data, it is not sent yet. For
     /// sending the request, see [`send`](struct.Request.html#method.send).
     ///
-    /// If `urlencoding` is not enabled, it is the responsibility of the
-    /// user to ensure there are no illegal characters in the URL.
-    ///
-    /// If `urlencoding` is enabled, the resource part of the URL will be
-    /// encoded. Any URL special characters (e.g. &, #, =) are not encoded
-    /// as they are assumed to be meaningful parameters etc.
+    /// The resource part of the URL will be encoded. Any URL special characters (e.g. &, #, =) are
+    /// not encoded as they are assumed to be meaningful parameters etc.
     pub fn new<T: Into<URL>>(method: Method, url: T) -> Request {
         Request {
             method,
@@ -153,17 +148,11 @@ impl Request {
     /// Adds given key and value as query parameter to request url
     /// (resource).
     ///
-    /// If `urlencoding` is not enabled, it is the responsibility
-    /// of the user to ensure there are no illegal characters in the
-    /// key or value.
-    ///
-    /// If `urlencoding` is enabled, the key and value are both encoded.
+    /// The key and value are both encoded.
     pub fn with_param<T: Into<String>, U: Into<String>>(mut self, key: T, value: U) -> Request {
         let key = key.into();
-        #[cfg(feature = "urlencoding")]
         let key = percent_encode_string(&key);
         let value = value.into();
-        #[cfg(feature = "urlencoding")]
         let value = percent_encode_string(&value);
 
         if !self.params.is_empty() {
@@ -612,7 +601,7 @@ mod parsing_tests {
     }
 }
 
-#[cfg(all(test, feature = "urlencoding"))]
+#[cfg(test)]
 mod encoding_tests {
     use super::{get, ParsedRequest};