Remove urlencoding dependence

Create a new function percent_encode_string to encode entire strings.
Use this instead of urlencoding::encode.

Author: jamillambert

bitreq/Cargo.toml

@@ -16,8 +16,6 @@ rust-version = "1.75.0"
 maintenance = { status = "experimental" }
 
 [dependencies]
-# For the urlencoding feature:
-urlencoding = { version = "2.1.0", optional = true }
 # For the punycode feature:
 punycode = { version = "0.4.1", optional = true }
 # For the json-using-serde feature:
@@ -53,6 +51,7 @@ json-using-serde = ["serde", "serde_json"]
 proxy = ["base64", "std"]
 async = ["tokio", "std"]
 async-https = ["async", "https-rustls", "tokio-rustls"]
+urlencoding = []
 
 [[example]]
 name = "hello"

bitreq/src/http_url.rs

@@ -201,3 +201,13 @@ pub(crate) fn percent_encode_char(c: char, result: &mut String) {
         }
     }
 }
+
+/// Percent-encodes the entire input string and returns the encoded version.
+#[cfg(feature = "urlencoding")]
+pub(crate) fn percent_encode_string(input: &str) -> String {
+    let mut encoded = String::with_capacity(input.len());
+    for ch in input.chars() {
+        percent_encode_char(ch, &mut encoded);
+    }
+    encoded
+}

bitreq/src/request.rs

@@ -7,6 +7,8 @@ use core::fmt::Write;
 use crate::connection::AsyncConnection;
 #[cfg(feature = "std")]
 use crate::connection::Connection;
+#[cfg(feature = "urlencoding")]
+use crate::http_url::percent_encode_string;
 #[cfg(feature = "std")]
 use crate::http_url::{HttpUrl, Port};
 #[cfg(feature = "proxy")]
@@ -159,10 +161,10 @@ impl Request {
     pub fn with_param<T: Into<String>, U: Into<String>>(mut self, key: T, value: U) -> Request {
         let key = key.into();
         #[cfg(feature = "urlencoding")]
-        let key = urlencoding::encode(&key);
+        let key = percent_encode_string(&key);
         let value = value.into();
         #[cfg(feature = "urlencoding")]
-        let value = urlencoding::encode(&value);
+        let value = percent_encode_string(&value);
 
         if !self.params.is_empty() {
             self.params.push('&');