Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove languageId from markdown cells #91

Open
christian-bromann opened this issue Dec 17, 2022 · 2 comments
Open

Remove languageId from markdown cells #91

christian-bromann opened this issue Dec 17, 2022 · 2 comments

Comments

@christian-bromann
Copy link
Contributor

It seems that for markdown sections we return a languageId property that is always empty. I guess we can remove this?

@adambabik
Copy link
Collaborator

I was thinking about hiding it when it's empty but if I read TS correctly, NotebookCellData requires presence of languageId always.

@christian-bromann
Copy link
Contributor Author

That is true, however it should not be a concern for the runme CLI as it should provide an ideal interface for what it is doing and not be too dependent on VS Code. In fact we don't even use/access the property. So there is not really a value to be 1:1 compliant with the VS Code API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants