Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow deletion of kit items -- only deactivation. #4817

Closed
2 tasks
cielf opened this issue Dec 1, 2024 · 2 comments · Fixed by #4837
Closed
2 tasks

Don't allow deletion of kit items -- only deactivation. #4817

cielf opened this issue Dec 1, 2024 · 2 comments · Fixed by #4837
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Dec 1, 2024

Summary

Prevent deletion of items that represent kits -- only allow deactivate

Why

it causes problems, including 500 errors when accessing the Inventor|Items and Inventory area

Details

The rules for showing deletion versus deactivation for items need to change to check whether the item represents a kit. If it does, the deletion button should not be shown, but the deactivation button instead.

To see the buttons, sign in as [email protected], then click "Inventory", then "Items & Inventory".

Criteria for completion

  • tests to support above behaviour
  • change to button behaviour completed
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Dec 1, 2024
@MichaScant
Copy link
Contributor

Hey, can I work on this?

@cielf
Copy link
Collaborator Author

cielf commented Dec 4, 2024

Hey Micah -- I think this is your first time contributing? We usually start people with one issue at a time to make sure they get through all the set up, etc. I'm assigning you this one, as it's simpler, but feel free to chime in on the other one again once it's done if no one else has picked it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants