Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Error" status filter on Partner Agency Index #4772

Closed
2 tasks
cielf opened this issue Nov 10, 2024 · 6 comments · Fixed by #4786
Closed
2 tasks

Remove "Error" status filter on Partner Agency Index #4772

cielf opened this issue Nov 10, 2024 · 6 comments · Fixed by #4786
Labels
Difficulty—Beginner Help Wanted Groomed + open to all!

Comments

@cielf
Copy link
Collaborator

cielf commented Nov 10, 2024

Summary

There is an outdated "Error" status filter on the partner agency index. Remove it.

Why

Outdated -- probably a holdover from when we had separate partner and bank apps

Details

To see this, sign in as [email protected], then click "Partner Agencies" and "All Partners".

Image

Remove the "0 Error" as shown above, and other code that specifically works with that.

Criteria for completion

  • removal of the error filtering as described above, including error-filtering-specific tests, if any
  • remaining partner-filtering tests still work.
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Nov 10, 2024
@EfeAgare
Copy link
Contributor

Can I take this issue?

@cielf
Copy link
Collaborator Author

cielf commented Nov 12, 2024

Yes you may!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Nov 12, 2024
@EfeAgare EfeAgare mentioned this issue Nov 16, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf
Copy link
Collaborator Author

cielf commented Dec 21, 2024

It should be pretty easy to finish off the PR associated with this-- there are some specs that assume that the error status is available to be built that are failing. I'll probably take it on myself if no one snaps it up.

@cielf cielf added Help Wanted Groomed + open to all! and removed stale labels Dec 21, 2024
@EfeAgare
Copy link
Contributor

@cielf I've removed the failing spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty—Beginner Help Wanted Groomed + open to all!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove error from display in UI EfeAgare/human-essentials
2 participants
@cielf @EfeAgare