Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Non-org root page - Fix button contrast on hover #1063

Closed
Kritika745 opened this issue Oct 17, 2024 · 8 comments
Closed

UI: Non-org root page - Fix button contrast on hover #1063

Kritika745 opened this issue Oct 17, 2024 · 8 comments
Assignees
Labels

Comments

@Kritika745
Copy link

Kritika745 commented Oct 17, 2024

Visit the root home page. At the bottom there is a button/link "learn more about ruby for good". When hovering over the button, the text is difficult to read. Fix the contrast of the button/text on hover. Preferably using bootstrap and geekui.

Screenshot from 2024-11-28 08-09-52

FIX
Screenshot 2024-10-17 092427

@kasugaijin
Copy link
Collaborator

kasugaijin commented Oct 18, 2024

@Kritika745 thank you. All yours! May as well make it the purple primary button?

@Kritika745
Copy link
Author

Kritika745 commented Oct 18, 2024

@kasugaijin okay..I'll do it. Please add hactoberfest label

@coalest
Copy link
Contributor

coalest commented Oct 19, 2024

@Kritika745 FYI This repo has the hacktoberfest topic attached, so any PR that gets merged will count towards Hacktoberfest (even if it doesn't have the Hacktoberfest label). I completed Hacktoberfest by accident this way.

Copy link

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link

Automatically unassigned after 7 days of inactivity.

@github-actions github-actions bot removed the Stale label Nov 26, 2024
@jmilljr24 jmilljr24 changed the title Invisibility of the content of button just above the footer UI: Non-org root page - Fix button contrast on hover Nov 28, 2024
@jmilljr24 jmilljr24 added Ready Make a comment to get assigned. good first issue Good for newcomers labels Nov 28, 2024
@jmilljr24
Copy link
Collaborator

This is available for whoever is interested.

@Kritika745 if you want to be reassigned let me know unless someone beats you to it. Thank you for bringing this to our attention.

@atbalaji
Copy link
Contributor

atbalaji commented Dec 3, 2024

I would like to work on this. Also is it okay if the text color is white instead of current color. It will solve the contrast problem

@kasugaijin
Copy link
Collaborator

All yours @atbalaji id rather I’f we can keep the theme buttons so please check those and see if something works from there before introducing any custom classes or css! https://geeksui.codescandy.com/geeks/docs/buttons.html

Go to their docs > components to see the buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants