-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staff: As staff I can review an adopter's information on their application #1048
Comments
@kasugaijin Will Please Assign this |
@Aaryanpal how's this going? |
Issue up for grabs! |
Hi @kasugaijin I would like to work on this issue if it is still open.. |
All yours @sarvaiyanidhi |
Hi @kasugaijin , I believe that I need to upload some sample data from this location staff/external_form_upload Do you have any sample format of CSV which can be used to upload details, basically I need to know apart from person email field what all other fields needs to be uploaded? Not sure if required but I think we should also provide sample CSV format to download so that user can update data in it and upload it back. |
@sarvaiyanidhi for this there’s no defined dataset per se. We need to take the users latest form submission and then iterate over all of its form answers and show the question and response. You can make up whatever you like for the dummy data in the tests. For example you could include Each organization will have their own set of questions that get uploaded Does that help? |
Thanks @kasugaijin , I was just trying to upload sample CSV from /external_form_upload path but nothing was getting inserted in form_answers table so I thought I am missing something.. Never mind I will update seed data to insert some data in form_answers as well which can be used to display in required functionality. |
Yeh we might need to update the seed adopter account to have a form submission. If the adopter doesn’t have a form submission I don’t think it will upload. On my cell right now so can’t look at it just yet |
Also double check your CSv has the date time. Check the csv import service for what it looks for |
Sure thanks.. Will check it and try to upload accordingly |
@sarvaiyanidhi I have a csv file linked in #1112 that might help you. That should add a few form submission to "Alta" adopters. The email has to match a user in the db. You will probably want to watch the logs during upload as we currently do not have any UI indications for success/failure. |
Thanks @jmilljr24 I was able to get few sample form_answers updated using sample CSV. Just one question, I see that question_id is nil for submitted_answers so I think I need not worry about that data for this feature? @kasugaijin Using sample CSV, we have below details updated in forms_answers table along with other values like form_submission_id, organization_id | value | question_snapshot | Just want to confirm that when I am displaying information in new screen, I will also be displaying details like First Name, Last Name, Address, Phone Number along with other questions as I will loop through latest form_submission_answers or I need to filter these details like Name, Address etc and just display generic questions (like What type of pet are you interested in adopting? (Dog, Cat, Other)) and answers? |
@sarvaiyanidhi for now let’s display all of the associated form answers (question and answer). No need to filter anything |
When logged in as staff, I can go to
/adoption_application_reviews
to see all of the applications on a pet. But I cannot click on the adopter name to see their information.Every User has a Person model. So, each adopter's information is stored on the
person.latest_form_submission.form_answers
. This will give you a list of records, each with a question snapshot and value (answer). (Nice to know, these form answers will come from a CSV uploaded by staff that matches the Person's email with a response in the CSV from a form like Google form). We need to show these questions and answers to the staff. Note, that we don't need to worry about grouping questions, for MVP we will just show a list of questions and aswers, however they come in the CSV (it's likely grouped in the original form anyway so that grouping should be loosely retained here).To do:
Organizations::Staff::AdoptionApplicationReviewsController
that will show the adopter's information. This information is stored as form answers on the adopter's Person model's latest_form_submission.review_adopter_applications
permissionQuestions and answers

The text was updated successfully, but these errors were encountered: