Improve report generation modal #5931
Conversation
wanguiwaweru
requested review from
compwron,
FireLemons,
littleforest and
elasticspoon
as code owners
| .input-style-1 select{ | ||
| width: 465px; | ||
| height: 40px; | ||
| border-radius: 5px; | ||
| border: 1px solid #4a6cf7; | ||
| } |
There was a problem hiding this comment.
This bit isn't actually showing up for me
I think it is because you are styling the select whereas you need to style the span that the select2 dropdown generates. Also it would be better if you could do the styles with bootstrap CSS classes. https://getbootstrap.com/docs/5.3/utilities/borders/#radius stuff line that.
| if(!$('#case-selection').val()){ | ||
| alert('Select an active case and specify the date range.'); | ||
| } |
There was a problem hiding this comment.
honestly i don't love how the default alert looks, I would like it to highlight the field that has the error.
I would be fine with this if I can be done as an HTML attribute otherwise lets just ditch the client side JS requirement.
|
This PR has been open for a long time without any pushes or comments! What's up? |
|
|
This PR has been open for a long time without any pushes or comments! What's up? |
What github issue is this PR for, if any?
Resolves #5888
What changed, and why?
Currently, the dropdown input in the modal to generate court report documents is not easily visible and users don't get an alert if they try to generate a report without selecting a case.
This PR improves the modal by :
How is this tested? (please write tests!) 💖💪
Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪
Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system
Screenshots please :)