chore: fix rubocop offenses

Also fixes a leaked file descriptor in the templator and a dead branch in
the fields.

Author: route

.rubocop.yml

@@ -6,6 +6,11 @@ AllCops:
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
+Naming/PredicateMethod:
+  AllowedMethods:
+    - page_snapshot
+    - prepare
+
 Naming/MethodParameterName:
   MinNameLength: 2
   AllowedNames:

lib/vessel/cargo.rb

@@ -7,9 +7,9 @@
 
 module Vessel
   class Cargo
-    def self.run(settings = nil, &block)
+    def self.run(settings = nil, &)
       self.settings.merge!(Hash(settings))
-      Engine.run(self, &block)
+      Engine.run(self, &)
     end
 
     def self.build_request(url:, **options)
@@ -34,6 +34,7 @@ def self.store_cookies(cookies)
     include Fieldable
     extend Settings
     extend Forwardable
+
     delegate %i[at_css css at_xpath xpath absolute_url join_url
                 url url_encode url_decode uri_encode uri_decode
                 data attempt body raw] => :response

lib/vessel/cargo/fieldable.rb

@@ -11,10 +11,10 @@ def fields
         @fields ||= Fields.new
       end
 
-      def field(name, *rest, &block)
+      def field(name, *rest, &)
         options = rest.last.is_a?(Hash) ? rest.pop : {}
         service = options.delete(:service)
-        field = Field.new(name: name, value: options[:value], context: self, **options, &block)
+        field = Field.new(name: name, value: options[:value], context: self, **options, &)
         value = field.apply
         if service
           fields.service[name.to_sym] = value

lib/vessel/cargo/fields.rb

@@ -7,7 +7,7 @@ class Fields
 
       def initialize(data = nil)
         @service = {}
-        @fields = data.to_h || {}
+        @fields = data.to_h
       end
 
       def []=(key, value)
@@ -26,8 +26,8 @@ def count
         @fields.count
       end
 
-      def select(&block)
-        @fields.send(:select, &block)
+      def select(&)
+        @fields.send(:select, &)
       end
 
       def zip(value)
@@ -46,8 +46,8 @@ def to_h
         @fields
       end
 
-      def each(&block)
-        @fields.each(&block)
+      def each(&)
+        @fields.each(&)
       end
     end
   end

lib/vessel/driver.rb

@@ -50,7 +50,6 @@ def create_page(proxy: nil)
     def restart
       stop
       start
-      true
     end
 
     def go_to(request)
@@ -81,7 +80,8 @@ def go_to(request)
           Logger.error("Driver: #{e.class}: #{e.message}")
           if attempt < settings[:network_error_attempts]
             attempt = visit(url)
-            restart && retry
+            restart
+            retry
           end
         end
 

lib/vessel/driver/ferrum/driver.rb

@@ -23,7 +23,7 @@ def self.direct_network_errors
 
         def start
           driver_options = settings.fetch(:driver_options, {})
-          @browser = ::Ferrum::Browser.new(**DEFAULT_OPTIONS.merge(driver_options))
+          @browser = ::Ferrum::Browser.new(**DEFAULT_OPTIONS, **driver_options)
         end
 
         def stop

lib/vessel/driver/ferrum/page.rb

@@ -7,6 +7,7 @@ class Driver
     module Ferrum
       class Page < Page
         extend Forwardable
+
         delegate %i[css at_css xpath at_xpath body current_url go_to] => :page
 
         attr_reader :page

lib/vessel/driver/mechanize/page.rb

@@ -7,6 +7,7 @@ class Driver
     module Mechanize
       class Page < Page
         extend Forwardable
+
         delegate %i[css at_css xpath at_xpath body] => :page
 
         attr_reader :mechanize

lib/vessel/engine.rb

@@ -6,18 +6,18 @@ module Vessel
   class Engine
     include Stats
 
-    def self.run(*args, &block)
-      new(*args, &block).tap(&:run)
+    def self.run(...)
+      new(...).tap(&:run)
     end
 
     attr_reader :crawler_class, :settings, :scheduler, :middleware_scheduler
 
-    def initialize(klass, &block)
+    def initialize(klass, &)
       @crawler_class = klass
       @settings = klass.settings
       @queue = SizedQueue.new(settings[:max_threads])
       @scheduler = Scheduler.new(@queue, settings)
-      @middleware_scheduler = MiddlewareScheduler.new(settings, &block)
+      @middleware_scheduler = MiddlewareScheduler.new(settings, &)
     end
 
     def run
@@ -61,7 +61,7 @@ def handle(response, request, error)
       Logger.debug("Engine: crawler starts processing #{response.url} with :#{response.handler}")
       crawler.send(*args) do |*result|
         result = result.flatten
-        if result.all? { |i| i.is_a?(Request) }
+        if result.all?(Request)
           Logger.debug("Engine: :#{response.handler} enqueued requests #{result.map { |r| r.url.to_s }}")
           schedule(result)
         else

lib/vessel/loader.rb

@@ -13,7 +13,7 @@ def templator
     end
 
     def load_crawlers
-      Dir["crawlers/**/*.rb"].sort.each { |file| require(file) }
+      Dir["crawlers/**/*.rb"].each { |file| require(file) }
     end
 
     def load_crawler(name)