Skip to content

Conversation

@eregon
Copy link
Member

@eregon eregon commented Nov 22, 2025

--category and --name_filters don't give a way to exclude some benchmarks.
--name_filters seems already quite complicated so adding some negated filter there seems undesirable.
Therefore I think it's best to add an explicit --excludes=x,y,z option.

Thanks to the recent refactor, this is pretty easy :)

There are many possible reasons to exclude a given benchmark notably too unstable performance, known to fail on some Ruby version and no point to even bundle install, etc.
This is vastly more convenient than having to manually exclude by including every other benchmark by name, especially as more benchmarks are added.

@eregon eregon requested a review from rafaelfranca November 22, 2025 13:21
Copy link
Contributor

@eightbitraptor eightbitraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great idea.

@eregon eregon merged commit 7db4e0b into ruby:main Nov 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants