Merge pull request #60 from ruby/type_inspect_params_fix

Improve inspect of recursively nested types

Author: tompng

lib/repl_type_completor/types.rb

@@ -273,7 +273,9 @@ def rbs_methods
       end
 
       def inspect
-        if params.empty?
+        if !@params && (@klass == Array || @klass == Hash) && @instances
+          "#{inspect_without_params}[unresolved]"
+        elsif params.empty?
           inspect_without_params
         else
           params_string = "[#{params.map { "#{_1}: #{_2.inspect}" }.join(', ')}]"

test/repl_type_completor/test_types.rb

@@ -55,8 +55,10 @@ def bo.hash; 42; end # Needed to use this object as a hash key
       assert_equal BasicObject, bo_key_hash_type.params[:K].klass
       assert_equal BasicObject, bo_value_hash_type.params[:V].klass
       assert_equal 'Object', obj_type.inspect
-      assert_equal 'Array[Elem: Integer | String]', arr_type.inspect
-      assert_equal 'Hash[K: String, V: Symbol]', hash_type.inspect
+      assert_equal 'Array[unresolved]', arr_type.inspect
+      assert_equal 'Array[Elem: Integer | String]', arr_type.tap(&:params).inspect
+      assert_equal 'Hash[unresolved]', hash_type.inspect
+      assert_equal 'Hash[K: String, V: Symbol]', hash_type.tap(&:params).inspect
       assert_equal 'Array.itself', ReplTypeCompletor::Types.type_from_object(Array).inspect
       assert_equal 'ReplTypeCompletor.itself', ReplTypeCompletor::Types.type_from_object(ReplTypeCompletor).inspect
     end
@@ -112,7 +114,17 @@ def test_params_lazily_expanded_on_recursive_type
         assert_equal expected, elem_type.types.map(&:klass).sort_by(&:name)
         type = elem_type.types.find { _1.klass == Array }
       end
-      assert_equal 'Hash[K: Integer, V: Float]', type.params[:Elem].types.find { _1.klass == Hash }.inspect
+      hash_type = type.params[:Elem].types.find { _1.klass == Hash }
+      assert_equal 'Hash[unresolved]', hash_type.inspect
+      assert_equal 'Hash[K: Integer, V: Float]', hash_type.tap(&:params).inspect
+    end
+
+    def test_infinite_nested_type_inspect
+      a = []
+      a << a
+      type = ReplTypeCompletor::Types.type_from_object a
+      assert_equal 'Array[unresolved]', type.inspect
+      assert_equal 'Array[Elem: Array[unresolved]]', type.tap(&:params).inspect
     end
   end
 end