Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ Add deprecation warnings to .new and #starttls #119

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Nov 8, 2024

  1. 🗑️ Add deprecation warnings to .new and #starttls [🚧 WIP]

    * `ssl` was renamed to `tls` in most places, with backwards compatible
      aliases.  Using `ssl` does not print any deprecation warnings.  Using
      both `tls` and `ssl` keywords raises an ArgumentError.
    
    * Preparing for a (backwards-incompatible) secure-by-default
      configuration, `Net::IMAP.default_tls` will determine the value for
      `tls` when no explicit port or tls setting is provided.  Using port
      143 will be insecure by default.  Using port 993 will be secure by
      default.  Providing no explicit port will use `Net::IMAP.default_tls`
      with the appropriate port.  And providing any other unknown port will
      use `default_tls` with a warning.
    
      🚧 TODO: should we use a different config var for default tls params
      when port is 993 and `tls` is unspecified?
    
      🚧 TODO: should we use a different config var for choosing `tls` when
      `port` is non-standard vs choosing `port` and `tls` when neither are
      specified?
    
      🚧 TODO: should we use a different var for `default_tls` be used to
      config params when port is 993 but tls is implicit? Another var?
    nevans committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    25199dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    272a3a5 View commit details
    Browse the repository at this point in the history