Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PasskeysControllerConcern to allow the response to be customized #53

Open
tcannonfodder opened this issue Dec 17, 2023 · 2 comments
Open

Fix PasskeysControllerConcern to allow the response to be customized #53

tcannonfodder opened this issue Dec 17, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tcannonfodder
Copy link
Contributor

Right now the actions are always redirecting to root_path. It should be customizable; maybe with special methods:

  • respond_to_after_create
  • respond_to_after_destroy
@tcannonfodder tcannonfodder added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Dec 17, 2023
@wilg
Copy link

wilg commented Apr 18, 2024

Ran into this today, too. I'm happy to fix it and make a PR, but I'm not sure if contributing to this repo is the active spot for an official Devise integration?

@tcannonfodder
Copy link
Contributor Author

tcannonfodder commented Apr 18, 2024 •
edited
Loading

Hey Wil!
Thanks so much for offering to help out here!! As of right now, this is the place to contribute; devise is not ready to add passkey support to the library itself yet.

Feel free to start a PR for this; and thanks again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wilg @tcannonfodder