Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cop idea: Replace be matchers with be_between matcher #1684

Open
ydakuka opened this issue Aug 5, 2023 · 0 comments
Open

Cop idea: Replace be matchers with be_between matcher #1684

ydakuka opened this issue Aug 5, 2023 · 0 comments

Comments

@ydakuka
Copy link

ydakuka commented Aug 5, 2023

Actual behavior

I have the following spec:

# frozen_string_literal: true

require 'rails_helper'

RSpec.describe ApplicationHelper do
  specify do
    expect(foo).to be >= 2
    expect(foo).to be <= 10
  end

  specify do
    expect(foo).to be <= 10
    expect(foo).to be >= 2
  end

  specify do
    expect(foo).to be > 1
    expect(foo).to be < 11
  end

  specify do
    expect(foo).to be < 11
    expect(foo).to be > 1
  end

  def foo
    2
  end
end

I run rubocop and don't get any offences:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop spec/helpers/application_helper_spec.rb 
Inspecting 1 file
.

1 file inspected, no offenses detected

Expected behavior

# frozen_string_literal: true

require 'rails_helper'

RSpec.describe ApplicationHelper do
  specify do
    expect(foo).to be_between(2, 10)
  end

  specify do
    expect(foo).to be_between(1, 11).exclusive
  end

  def foo
    2
  end
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.55.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-factory_bot 2.23.1
  - rubocop-performance 1.18.0
  - rubocop-rails 2.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.23.0
  - rubocop-thread_safety 0.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant