-
Notifications
You must be signed in to change notification settings - Fork 22
upload.dest setting causes all uploads to be considered (NEW) #19
Comments
I definitely need to get some tests in around this code. It's on my list of things to do, hopefully it happens here soon. My first hunch is to try putting in a leading slash so I'll see what I can dig up. |
I just tried |
Fun, I didn't see anything obvious in the code, and I know this use to work. I'll try to dig into in the next day or two. |
Thanks so much! I'l look into it as well. |
Thanks to you @rtgibbons, this issue helped me to quickly understand why everything was always uploading as (NEW). Is there any update on this issue? Should I try to help you guys? |
any help is appreciated. My time is sped so thin right now at work, i haven't had time to work on these outstanding issues. Any help that is accompanied any type of unit tests would be even cooler. |
This fixes the issue where the call to client.getFile does not take into account the destination when trying to compare the file being uploaded to what already exists on the server. This fixes issue rtgibbons#19 on Github and also solves the problem I was having where I wanted to add the files to a subdirectory after having already added them to the root.
when
upload.dest = '/'
, it works as expected and only new files are uploaded. I changed it toupload.dest='assets/'
, and now it uploads every file as (NEW).The text was updated successfully, but these errors were encountered: