Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

upload.dest setting causes all uploads to be considered (NEW) #19

Open
azhang opened this issue Nov 5, 2013 · 6 comments
Open

upload.dest setting causes all uploads to be considered (NEW) #19

azhang opened this issue Nov 5, 2013 · 6 comments

Comments

@azhang
Copy link

azhang commented Nov 5, 2013

when upload.dest = '/', it works as expected and only new files are uploaded. I changed it to upload.dest='assets/', and now it uploads every file as (NEW).

@rtgibbons
Copy link
Owner

I definitely need to get some tests in around this code. It's on my list of things to do, hopefully it happens here soon.

My first hunch is to try putting in a leading slash so upload.dest='/assets/' , it didn't use to require it, but last time I used this was before we moved to pkgcloud.

I'll see what I can dig up.

@azhang
Copy link
Author

azhang commented Nov 12, 2013

I just tried '/assets/' and unfortunately, everything still says (NEW).

@rtgibbons
Copy link
Owner

Fun, I didn't see anything obvious in the code, and I know this use to work. I'll try to dig into in the next day or two.

@azhang
Copy link
Author

azhang commented Nov 13, 2013

Thanks so much! I'l look into it as well.

@nrako
Copy link

nrako commented Dec 12, 2013

Thanks to you @rtgibbons, this issue helped me to quickly understand why everything was always uploading as (NEW). Is there any update on this issue? Should I try to help you guys?

@rtgibbons
Copy link
Owner

any help is appreciated. My time is sped so thin right now at work, i haven't had time to work on these outstanding issues.

Any help that is accompanied any type of unit tests would be even cooler.

jschniper pushed a commit to jschniper/grunt-cloudfiles that referenced this issue Jun 4, 2014
This fixes the issue where the call to client.getFile does not take into
account the destination when trying to compare the file being uploaded
to what already exists on the server. This fixes issue rtgibbons#19 on Github and
also solves the problem I was having where I wanted to add the files to
a subdirectory after having already added them to the root.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants