Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_tests doesn't work for bootstrap #379

Open
jkderrick028 opened this issue Dec 3, 2023 · 1 comment
Open

all_tests doesn't work for bootstrap #379

jkderrick028 opened this issue Dec 3, 2023 · 1 comment

Comments

@jkderrick028
Copy link

jkderrick028 commented Dec 3, 2023

Thanks for considering reporting an issue in rsatoolbox to us! Below are some tips that make it easier for us to understand what happened.

Describe the bug
rsatoolbox.vis.plot_model_comparison does not run when setting the test_type to 'bootstrap'. Potentially due to
elif test_type == 'bootstrap': if len(noise_ceil.shape) > 1: noise_lower_bs = noise_ceil[0] noise_lower_bs.shape = (noise_ceil.shape[0], 1) in interence_util.all_tests
should remove noise_lower_bs.shape = (noise_ceil.shape[0], 1)?

To Reproduce
the results come out of bootstrap_crossval, with boot_type='rdm', k_pattern=1

Expected behavior
A clear and concise description of what you expected to happen.

Plots
If the bug is related to plotting code, please attach the image(s).

Versions
Please report:

  • the version of rsatoolbox you used (pip freeze | grep rsatoolbox) 0.1.5
  • the version of python you used (python --version) 3.8

Additional context
Add any other context about the problem here.

stack trace
This is the error information that python printed. You can add this in the body of this issue, wrapped in triple backticks (```) or attach it in a text file

@JasperVanDenBosch
Copy link
Contributor

Thanks Derrick, indeed that line seems unusual. We'll investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants