Skip to content

only define htonl where missing #4010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

only define htonl where missing #4010

merged 1 commit into from
Sep 16, 2025

Conversation

@GitMensch
Copy link
Contributor

@GitMensch GitMensch commented Aug 25, 2025 •
edited
Loading

  • glibc has that as a define
  • muslc and others have that as a function, which leads to a build failure, as seen in the Alpine CI #4009 build log.
  • Android API level 20 misses it

@GitMensch GitMensch marked this pull request as ready for review September 15, 2025 18:30
@GitMensch
only define htonl where missing
cfe4993 
* glibc has that as a define
* muslc and others have that as a function
* Android API level 20 misses it
@GitMensch
Copy link
Contributor Author

GitMensch commented Sep 15, 2025

I claim that the failing test

966 - alternate_thread_diversion-no-syscallbuf (Failed)

is totally unrelated as this PR changes a single different test.

@rocallahan rocallahan merged commit 5cbdfed into rr-debugger:master Sep 16, 2025
4 of 5 checks passed
@GitMensch GitMensch deleted the patch-3 branch September 16, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GitMensch @rocallahan