Compile errors with master on Alpine Linux edge

[russkel]

Trying to compile master on Alpine Linux edge (uses musl libc), gcc 8.3.0 and I am getting these errors:

[ 34%] Building C object CMakeFiles/rrpreload.dir/src/preload/syscallbuf.c.o
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c: In function 'init_process':
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c:668:29: warning: implicit declaration of function 'dlsym' [-Wimplicit-function-declaration]
   real_pthread_mutex_lock = dlsym(RTLD_NEXT, "pthread_mutex_lock");
                             ^~~~~
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c:668:35: error: 'RTLD_NEXT' undeclared (first use in this function)
   real_pthread_mutex_lock = dlsym(RTLD_NEXT, "pthread_mutex_lock");
                                   ^~~~~~~~~
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c:668:35: note: each undeclared identifier is reported only once for each function it appears in
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c: In function 'sys_recvmsg':
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c:2245:17: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [-Wsign-compare]
   for (i = 0; i < msg->msg_iovlen; ++i) {
                 ^
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c:2276:17: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [-Wsign-compare]
   for (i = 0; i < msg->msg_iovlen; ++i) {
                 ^
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c:2296:19: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [-Wsign-compare]
     for (i = 0; i < msg->msg_iovlen; ++i) {
                   ^
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c: In function 'sys_ptrace':
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c:2621:8: error: variable 'request' has initializer but incomplete type
   enum __ptrace_request request = call->args[0];
        ^~~~~~~~~~~~~~~~
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c:2621:25: error: storage size of 'request' isn't known
   enum __ptrace_request request = call->args[0];
                         ^~~~~~~
/apk_src/rr/src/rr-master/src/preload/syscallbuf.c:2621:25: warning: unused variable 'request' [-Wunused-variable]
make[2]: *** [CMakeFiles/rrpreload.dir/build.make:68: CMakeFiles/rrpreload.dir/src/preload/syscallbuf.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:287: CMakeFiles/rrpreload.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

The first error seems to an issue because of the non-inclusion of <dlfcn.h>

Another error with a test:

/apk_src/rr/src/rr-master/src/test/ptrace_remote_unmap.c:8:26: warning: 'enum __ptrace_request' declared inside parameter list will not be visible outside of this definition or declaration
 long checked_ptrace(enum __ptrace_request request, pid_t pid, void* addr,
                          ^~~~~~~~~~~~~~~~
/apk_src/rr/src/rr-master/src/test/ptrace_remote_unmap.c:8:43: error: parameter 1 ('request') has incomplete type
 long checked_ptrace(enum __ptrace_request request, pid_t pid, void* addr,
                     ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/apk_src/rr/src/rr-master/src/test/ptrace_remote_unmap.c:8:6: warning: function declaration isn't a prototype [-Wstrict-prototypes]
 long checked_ptrace(enum __ptrace_request request, pid_t pid, void* addr,
      ^~~~~~~~~~~~~~
/apk_src/rr/src/rr-master/src/test/ptrace_remote_unmap.c: In function 'checked_ptrace':
/apk_src/rr/src/rr-master/src/test/ptrace_remote_unmap.c:8:43: warning: unused parameter 'request' [-Wunused-parameter]
 long checked_ptrace(enum __ptrace_request request, pid_t pid, void* addr,
                     ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
make[2]: *** [CMakeFiles/ptrace_remote_unmap.dir/build.make:63: CMakeFiles/ptrace_remote_unmap.dir/src/test/ptrace_remote_unmap.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1617: CMakeFiles/ptrace_remote_unmap.dir/all] Error 2

[ 39%] Building CXX object CMakeFiles/rr.dir/src/AutoRemoteSyscalls.cc.o
In file included from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:23:
/apk_src/lsa/rr/src/rr-master/src/log.h:156:53: error: missing binary operator before token "("
 #if __has_builtin(__builtin_expect) || __GNUC_PREREQ(4, 0)
                                                     ^
In file included from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:18:
/apk_src/lsa/rr/src/rr-master/src/log.h:156:53: error: missing binary operator before token "("
 #if __has_builtin(__builtin_expect) || __GNUC_PREREQ(4, 0)
                                                     ^
In file included from /usr/include/fortify/unistd.h:22,
                 from /usr/include/sys/user.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/Registers.h:11,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:312:19: error: redeclaration of 'typedef int64_t rr::BaseArch<arch_, wordsize>::off_t'
   typedef int64_t off64_t;
                   ^~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/Registers.h:15,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:303:27: note: previous declaration 'typedef rr::BaseArch<arch_, wordsize>::syscall_slong_t rr::BaseArch<arch_, wordsize>::off_t'
   typedef syscall_slong_t off_t;
                           ^~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1545,
                 from /apk_src/lsa/rr/src/rr-master/src/Registers.h:15,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:212:16: error: redeclaration of 'truncate'
   truncate64 = 193,
                ^~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:111:3: note: previous declaration 'truncate'
   truncate = 92,
   ^~~~~~~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:213:17: error: redeclaration of 'ftruncate'
   ftruncate64 = 194,
                 ^~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:112:3: note: previous declaration 'ftruncate'
   ftruncate = 93,
   ^~~~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1702,
                 from /apk_src/lsa/rr/src/rr-master/src/Registers.h:15,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:144:14: error: redeclaration of 'truncate'
   truncate = 76,
              ^~
In file included from /usr/include/fortify/unistd.h:22,
                 from /usr/include/sys/user.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/Registers.h:11,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:39:3: note: previous declaration 'truncate'
   truncate64 = -38,
   ^~~~~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1702,
                 from /apk_src/lsa/rr/src/rr-master/src/Registers.h:15,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:145:15: error: redeclaration of 'ftruncate'
   ftruncate = 77,
               ^~
In file included from /usr/include/fortify/unistd.h:22,
                 from /usr/include/sys/user.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/Registers.h:11,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:40:3: note: previous declaration 'ftruncate'
   ftruncate64 = -39,
   ^~~~~~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/ScopedFd.h:6,
                 from /apk_src/lsa/rr/src/rr-master/src/EmuFs.h:11,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:20,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:312:19: error: redeclaration of 'typedef int64_t rr::BaseArch<arch_, wordsize>::off_t'
   typedef int64_t off64_t;
                   ^~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:303:27: note: previous declaration 'typedef rr::BaseArch<arch_, wordsize>::syscall_slong_t rr::BaseArch<arch_, wordsize>::off_t'
   typedef syscall_slong_t off_t;
                           ^~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/ScopedFd.h:6,
                 from /apk_src/lsa/rr/src/rr-master/src/EmuFs.h:11,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:20,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:313:19: error: redeclaration of 'typedef int64_t rr::BaseArch<arch_, wordsize>::off_t'
   typedef int64_t loff_t;
                   ^~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:303:27: note: previous declaration 'typedef rr::BaseArch<arch_, wordsize>::syscall_slong_t rr::BaseArch<arch_, wordsize>::off_t'
   typedef syscall_slong_t off_t;
                           ^~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/preload/preload_interface.h:55,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:18,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:315:20: error: redeclaration of 'typedef uint64_t rr::BaseArch<arch_, wordsize>::ino_t'
   typedef uint64_t ino64_t;
                    ^~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:309:27: note: previous declaration 'typedef rr::BaseArch<arch_, wordsize>::syscall_ulong_t rr::BaseArch<arch_, wordsize>::ino_t'
   typedef syscall_ulong_t ino_t;
                           ^~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/preload/preload_interface.h:55,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:18,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:316:19: error: redeclaration of 'typedef int64_t rr::BaseArch<arch_, wordsize>::blkcnt_t'
   typedef int64_t blkcnt64_t;
                   ^~~~~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:304:27: note: previous declaration 'typedef rr::BaseArch<arch_, wordsize>::syscall_slong_t rr::BaseArch<arch_, wordsize>::blkcnt_t'
   typedef syscall_slong_t blkcnt_t;
                           ^~~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1545,
                 from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:212:16: error: redeclaration of 'truncate'
   truncate64 = 193,
                ^~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:111:3: note: previous declaration 'truncate'
   truncate = 92,
   ^~~~~~~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:213:17: error: redeclaration of 'ftruncate'
   ftruncate64 = 194,
                 ^~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:112:3: note: previous declaration 'ftruncate'
   ftruncate = 93,
   ^~~~~~~~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:214:12: error: redeclaration of 'stat'
   stat64 = 195,
            ^~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:125:3: note: previous declaration 'stat'
   stat = 106,
   ^~~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:215:13: error: redeclaration of 'lstat'
   lstat64 = 196,
             ^~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:126:3: note: previous declaration 'lstat'
   lstat = 107,
   ^~~~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:216:13: error: redeclaration of 'fstat'
   fstat64 = 197,
             ^~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:127:3: note: previous declaration 'fstat'
   fstat = 108,
   ^~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1667:34: error: redefinition of 'struct rr::X86Arch::stat'
   struct __attribute__((packed)) stat64 {
                                  ^~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1646:10: note: previous definition of 'struct rr::X86Arch::stat'
   struct stat {
          ^~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1702,
                 from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:72:10: error: redeclaration of 'stat'
   stat = 4,
          ^
In file included from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:41:3: note: previous declaration 'stat'
   stat64 = -40,
   ^~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1702,
                 from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:73:11: error: redeclaration of 'fstat'
   fstat = 5,
           ^
In file included from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:43:3: note: previous declaration 'fstat'
   fstat64 = -42,
   ^~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1702,
                 from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:74:11: error: redeclaration of 'lstat'
   lstat = 6,
           ^
In file included from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:42:3: note: previous declaration 'lstat'
   lstat64 = -41,
   ^~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1702,
                 from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:144:14: error: redeclaration of 'truncate'
   truncate = 76,
              ^~
In file included from /usr/include/fortify/unistd.h:22,
                 from /usr/include/sys/user.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/preload/preload_interface.h:56,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:18,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:39:3: note: previous declaration 'truncate'
   truncate64 = -38,
   ^~~~~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1702,
                 from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:145:15: error: redeclaration of 'ftruncate'
   ftruncate = 77,
               ^~
In file included from /usr/include/fortify/unistd.h:22,
                 from /usr/include/sys/user.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/preload/preload_interface.h:56,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:18,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX64.generated:40:3: note: previous declaration 'ftruncate'
   ftruncate64 = -39,
   ^~~~~~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1832:10: error: redefinition of 'struct rr::X64Arch::stat'
   struct stat64 {
          ^~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/remote_code_ptr.h:7,
                 from /apk_src/lsa/rr/src/rr-master/src/Monkeypatcher.h:12,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.h:23,
                 from /apk_src/lsa/rr/src/rr-master/src/AddressSpace.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1813:10: note: previous definition of 'struct rr::X64Arch::stat'
   struct stat {
          ^~~~
make[2]: *** [CMakeFiles/rr.dir/build.make:88: CMakeFiles/rr.dir/src/AutoRemoteSyscalls.cc.o] Error 1

And a warning:

[ 16%] Building C object CMakeFiles/ftrace_helper.dir/src/ftrace/ftrace_helper.c.o
In file included from /apk_src/rr/src/rr-master/src/ftrace/ftrace_helper.c:26:
/apk_src/rr/src/rr-master/src/ftrace/ftrace_helper.c: In function 'open_control_fd':
/apk_src/rr/src/rr-master/src/ftrace/ftrace_helper.c:277:30: warning: passing argument 2 of 'bind' from incompatible pointer type [-Wincompatible-pointer-types]
   check(0 == bind(listen_fd, &addr, sizeof(addr)));
                              ^~~~~
/apk_src/rr/src/rr-master/src/ftrace/ftrace_helper.c:277:3: note: in expansion of macro 'check'
   check(0 == bind(listen_fd, &addr, sizeof(addr)));
   ^~~~~
In file included from /usr/include/fortify/sys/socket.h:22,
                 from /apk_src/rr/src/rr-master/src/ftrace/ftrace_helper.c:16:
/usr/include/sys/socket.h:331:16: note: expected 'const struct sockaddr *' but argument is of type 'struct sockaddr_un *'
 int bind (int, const struct sockaddr *, socklen_t);
                ^~~~~~~~~~~~~~~~~~~~~~~

Any suggestions? Thanks.

[khuey]

What compiler are you using?

[russkel]

@khuey gcc 8.3.0 on Alpine Linux edge w/ musl libc. I can provide Dockerfile and package script if that would be helpful.

[rocallahan]

I'm not sure what's going on with the missing definition of __ptrace_request. man 2 ptrace says

       #include <sys/ptrace.h>

       long ptrace(enum __ptrace_request request, pid_t pid,
                   void *addr, void *data);

and I thought that meant enum __ptrace_request must be defined by sys/ptrace.h.

[rocallahan]

That is likely to be a musl issue.

[rocallahan]

In file included from /usr/include/fortify/unistd.h:22,
                 from /usr/include/sys/user.h:9,
                 from /apk_src/lsa/rr/src/rr-master/src/Registers.h:11,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:312:19: error: redeclaration of 'typedef int64_t rr::BaseArch<arch_, wordsize>::off_t'
   typedef int64_t off64_t;
                   ^~~~~~~
In file included from /apk_src/lsa/rr/src/rr-master/src/Registers.h:15,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:303:27: note: previous declaration 'typedef rr::BaseArch<arch_, wordsize>::syscall_slong_t rr::BaseArch<arch_, wordsize>::off_t'
   typedef syscall_slong_t off_t;
                           ^~~~~

Apparently musl has #defined off64_t to off_t. I'm surprised that's allowed.

[rocallahan]

In file included from /apk_src/lsa/rr/src/rr-master/src/kernel_abi.h:1545,
                 from /apk_src/lsa/rr/src/rr-master/src/Registers.h:15,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.h:10,
                 from /apk_src/lsa/rr/src/rr-master/src/AutoRemoteSyscalls.cc:3:
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:212:16: error: redeclaration of 'truncate'
   truncate64 = 193,
                ^~~
/apk_src/lsa/rr/src/rr-master/SyscallEnumsX86.generated:111:3: note: previous declaration 'truncate'
   truncate = 92,
   ^~~~~~~~

Likewise it appears to have #defined truncate64 to truncate, which seems very unwise.

[rocallahan]

I landed 64d494c which fixes a couple of genuinely missing #includes, and bb7ae39 to fix the bind parameter type, but as far as I can tell the other errors are caused by musl just being kind of broken and I don't really want to have to work around that. I'm also not sure if rr would actually work properly with musl even if you did work around that.

[russkel]

I don't really want to have to work around that

Naturally. I will raise it with the musl people and see what they say.

I'm also not sure if rr would actually work properly with musl even if you did work around that.

Oh, could you please elaborate?

[rocallahan]

rr's preload library does some tricky stuff with overriding libc functions. That might have no effect with musl, it might not be needed with musl, or it might break with musl.

[russkel]

I see. Thanks for the fixes. It has cleaned up a few of the errors.

[richfelker]

Apparently musl has #defined off64_t to off_t. I'm surprised that's allowed.

It's not, but we don't do it in any standards-conforming profile. It only happens if _GNU_SOURCE is defined. Unfortunately GCC insists on always defining this when acting as a C++ compiler, which means there's no way to get a conforming, namespace-clean environment with C++ on GCC.

Everything the headers do with the *64 symbols on musl is something we don't want to be doing at all (we don't want to even be offering the broken LFS64 APIs; off_t is always 64-bit regardless), but "had to do" because broken configure scripts were detecting the presence of the glibc-ABI-compat symbols *64 via fake declarations and link-only checks, and then assuming they could use the APIs at the source level, and things broke catastrophically due to implicit function declarations, which really don't play nicely with 64-bit arguments on 32-bit systems. I want to rip all this out soon and find a way to make the *64 stuff ABI-compat only, unusable at the source level, but I don't know how much fallout there will be in terms of stuff needing to be fixed still.

[rocallahan]

My condolences.