fix rubocop offenses

Author: rossta

.rubocop.yml

@@ -45,8 +45,11 @@ Style/AndOr:
 Style/Not:
   Enabled: false
 
+Style/SingleSpaceBeforeFirstArg:
+  Enabled: false
+
 Documentation:
-  Enabled: false # TODO: Enable again once we have more docs
+  Enabled: false
 
 Style/CaseIndentation:
   IndentWhenRelativeTo: case

Gemfile

@@ -1,63 +1,63 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-ruby '2.1.5'
+ruby "2.1.5"
 
-gem 'rails', '4.2.0'
+gem "rails", "4.2.0"
 
-gem 'sass-rails', '~> 5.0'
-gem 'uglifier', '>= 1.3.0'
-gem 'coffee-rails', '~> 4.1.0'
-gem 'jquery-rails'
-gem 'foundation-rails'
-gem 'turbolinks'
-gem 'bower-rails'
+gem "sass-rails", "~> 5.0"
+gem "uglifier", ">= 1.3.0"
+gem "coffee-rails", "~> 4.1.0"
+gem "jquery-rails"
+gem "foundation-rails"
+gem "turbolinks"
+gem "bower-rails"
 
-gem 'high_voltage'
-gem 'omniauth'
-gem 'omniauth-oauth2'
+gem "high_voltage"
+gem "omniauth"
+gem "omniauth-oauth2"
 
-gem 'pg'
-gem 'puma'
-gem 'devise'
+gem "pg"
+gem "puma"
+gem "devise"
 
-gem 'pundit'
-gem 'simple_form'
+gem "pundit"
+gem "simple_form"
 
 group :development do
-  gem 'better_errors'
-  gem 'binding_of_caller', :platforms=>[:mri_21]
-  gem 'foreman'
-  gem 'guard-bundler'
-  gem 'guard-rails'
-  gem 'guard-rspec'
-  gem 'quiet_assets'
-  gem 'rails_layout'
-  gem 'rb-fchange', :require=>false
-  gem 'rb-fsevent', :require=>false
-  gem 'rb-inotify', :require=>false
-  gem 'spring-commands-rspec'
+  gem "better_errors"
+  gem "binding_of_caller", platforms: [:mri_21]
+  gem "foreman"
+  gem "guard-bundler"
+  gem "guard-rails"
+  gem "guard-rspec"
+  gem "quiet_assets"
+  gem "rails_layout"
+  gem "rb-fchange", require: false
+  gem "rb-fsevent", require: false
+  gem "rb-inotify", require: false
+  gem "spring-commands-rspec"
 end
 
 group :development, :test do
-  gem 'factory_girl_rails'
-  gem 'faker'
-  gem 'seed-fu'
-  gem 'pry-rails'
-  gem 'pry-rescue'
-  gem 'pry-byebug'
-  gem 'rspec-rails'
-  gem 'rubocop'
-  gem 'web-console', '~> 2.0'
-  gem 'spring'
+  gem "factory_girl_rails"
+  gem "faker"
+  gem "seed-fu"
+  gem "pry-rails"
+  gem "pry-rescue"
+  gem "pry-byebug"
+  gem "rspec-rails"
+  gem "rubocop"
+  gem "web-console", "~> 2.0"
+  gem "spring"
 end
 
 group :production do
-  gem 'rails_12factor'
+  gem "rails_12factor"
 end
 
 group :test do
-  gem 'capybara'
-  gem 'database_cleaner'
-  gem 'launchy'
-  gem 'selenium-webdriver'
+  gem "capybara"
+  gem "database_cleaner"
+  gem "launchy"
+  gem "selenium-webdriver"
 end

Rakefile

@@ -1,6 +1,6 @@
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('../config/application', __FILE__)
+require File.expand_path("../config/application", __FILE__)
 
 Rails.application.load_tasks

app/helpers/application_helper.rb

@@ -1,5 +1,4 @@
 module ApplicationHelper
-
   def memberful_signup_path
     "https://rosskaff-example.memberful.com/register"
   end

app/models/user.rb

@@ -1,6 +1,6 @@
 class User < ActiveRecord::Base
   enum role: [:user, :vip, :admin]
-  after_initialize :set_default_role, :if => :new_record?
+  after_initialize :set_default_role, if: :new_record?
 
   def set_default_role
     if User.count == 0
@@ -13,23 +13,23 @@ def set_default_role
   def attributes_from_omniauth=(auth)
     self.uid ||= auth.uid
     self.provider ||= auth.provider
+    info = auth.info
+    extra = auth.extra
 
-    if info = auth.info
+    # rubocop: disable Style/GuardClause
+    if info
       self.username = info.nickname
       self.name = info.name
       self.first_name = info.first_name
       self.last_name = info.last_name
       self.email = info.email
     end
 
-    if extra = auth.extra and
-      raw_info = extra.raw_info and
-      member = raw_info.member
-
+    if extra && extra.raw_info && extra.raw_info.member
       self.membership_created_at = Time.at(member.created_at)
       self.unrestricted_access = member.unrestricted_access
       self.stripe_customer_id = member.stripe_customer_id
     end
+    # rubocop: enable Style/GuardClause
   end
-
 end

config/application.rb

@@ -1,14 +1,13 @@
-require File.expand_path('../boot', __FILE__)
+require File.expand_path("../boot", __FILE__)
 
-require 'rails/all'
+require "rails/all"
 
 # Require the gems listed in Gemfile, including any gems
-# you've limited to :test, :development, or :production.
+# you"ve limited to :test, :development, or :production.
 Bundler.require(*Rails.groups)
 
 module MemberfulExample
   class Application < Rails::Application
-
     config.generators do |g|
       g.test_framework :rspec,
         fixtures: true,
@@ -26,14 +25,14 @@ class Application < Rails::Application
 
     # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
     # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
-    # config.time_zone = 'Central Time (US & Canada)'
+    # config.time_zone = "Central Time (US & Canada)"
 
     # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
-    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
+    # config.i18n.load_path += Dir[Rails.root.join("my", "locales", "*.{rb,yml}").to_s]
     # config.i18n.default_locale = :de
 
     # For Foundation 5
-    config.assets.precompile += %w( vendor/modernizr )
+    config.assets.precompile += %w[vendor/modernizr]
 
     # Do not swallow errors in after_commit/after_rollback callbacks.
     config.active_record.raise_in_transactional_callbacks = true

config/boot.rb

@@ -1,3 +1,3 @@
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
 
-require 'bundler/setup' # Set up gems listed in the Gemfile.
+require "bundler/setup" # Set up gems listed in the Gemfile.

config/environment.rb

@@ -1,5 +1,5 @@
 # Load the Rails application.
-require File.expand_path('../application', __FILE__)
+require File.expand_path("../application", __FILE__)
 
 # Initialize the Rails application.
 Rails.application.initialize!

config/environments/development.rb

@@ -1,9 +1,9 @@
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 
-  # In the development environment your application's code is reloaded on
+  # In the development environment your application"s code is reloaded on
   # every request. This slows down response time but is perfect for development
-  # since you don't have to restart the web server when you make code changes.
+  # since you don"t have to restart the web server when you make code changes.
   config.cache_classes = false
 
   # Do not eager load code on boot.
@@ -13,7 +13,7 @@
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
 
-  # Don't care if the mailer can't send.
+  # Don"t care if the mailer can"t send.
   config.action_mailer.raise_delivery_errors = false
 
   # Print deprecation notices to the Rails logger.
@@ -37,7 +37,7 @@
     password: Rails.application.secrets.email_provider_apikey
   }
   # ActionMailer Config
-  config.action_mailer.default_url_options = { :host => 'localhost:3000' }
+  config.action_mailer.default_url_options = { host: "localhost:3000" }
   config.action_mailer.delivery_method = :smtp
   config.action_mailer.raise_delivery_errors = true
   # Send email in development mode?

config/environments/production.rb

@@ -22,7 +22,7 @@
 
   # Disable serving static files from the `/public` folder by default since
   # Apache or NGINX already handles this.
-  config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
+  config.serve_static_files = ENV["RAILS_SERVE_STATIC_FILES"].present?
 
   # Compress JavaScripts and CSS.
   config.assets.js_compressor = :uglifier
@@ -38,8 +38,8 @@
   # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb
 
   # Specifies the header that your server uses for sending files.
-  # config.action_dispatch.x_sendfile_header = 'X-Sendfile' # for Apache
-  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for NGINX
+  # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for Apache
+  # config.action_dispatch.x_sendfile_header = "X-Accel-Redirect" # for NGINX
 
   # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
   # config.force_ssl = true
@@ -58,7 +58,7 @@
   # config.cache_store = :mem_cache_store
 
   # Enable serving of images, stylesheets, and JavaScripts from an asset server.
-  # config.action_controller.asset_host = 'http://assets.example.com'
+  # config.action_controller.asset_host = "http://assets.example.com"
 
   # Ignore bad email addresses and do not raise email delivery errors.
   # Set this to true and configure the email server for immediate delivery to raise delivery errors.
@@ -81,7 +81,7 @@
     password: Rails.application.secrets.email_provider_apikey
   }
   # ActionMailer Config
-  config.action_mailer.default_url_options = { :host => Rails.application.secrets.domain_name }
+  config.action_mailer.default_url_options = { host: Rails.application.secrets.domain_name }
   config.action_mailer.delivery_method = :smtp
   config.action_mailer.perform_deliveries = true
   config.action_mailer.raise_delivery_errors = false

config/environments/test.rb

@@ -1,10 +1,10 @@
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 
-  # The test environment is used exclusively to run your application's
+  # The test environment is used exclusively to run your application"s
   # test suite. You never need to work with it otherwise. Remember that
   # your test database is "scratch space" for the test suite and is wiped
-  # and recreated between test runs. Don't rely on the data there!
+  # and recreated between test runs. Don"t rely on the data there!
   config.cache_classes = true
 
   # Do not eager load code on boot. This avoids loading your whole application
@@ -14,7 +14,7 @@
 
   # Configure static file server for tests with Cache-Control for performance.
   config.serve_static_files   = true
-  config.static_cache_control = 'public, max-age=3600'
+  config.static_cache_control = "public, max-age=3600"
 
   # Show full error reports and disable caching.
   config.consider_all_requests_local       = false

config/initializers/assets.rb

@@ -1,7 +1,7 @@
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.
-Rails.application.config.assets.version = '1.0'
+Rails.application.config.assets.version = "1.0"
 
 # Add additional assets to the asset load path
 # Rails.application.config.assets.paths << Emoji.images_path

config/initializers/bower_rails.rb

@@ -1,6 +1,6 @@
 BowerRails.configure do |bower_rails|
   # Tell bower-rails what path should be considered as root. Defaults to Dir.pwd
-  # bower_rails.root_path = Dir.pwd
+  bower_rails.root_path = Dir.pwd
 
   # Invokes rake bower:install before precompilation. Defaults to false
   # bower_rails.install_before_precompile = true
@@ -10,7 +10,7 @@
 
   # Invokes rake bower:clean before precompilation. Defaults to false
   # bower_rails.clean_before_precompile = true
-  
+
   # Invokes rake bower:install:deployment instead rake bower:install. Defaults to false
   # bower_rails.use_bower_install_deployment = true
 end