Fixed visibility control file added to wrong header list variable. #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanFabian
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
clalancette
requested changes
Jun 20, 2023
rosidl_generator_cpp/cmake/rosidl_generator_cpp_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Fabian <[email protected]>
Signed-off-by: Stefan Fabian <[email protected]>
clalancette
approved these changes
Jun 21, 2023
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Thanks for the fix. This looks good to me now. I'll run CI on it next.
Contributor
|
CI:
|
|
Regrettably, this change broke all of the prior work done to decouple IDL target generation from CMake by creating a new file that is only generated by CMake and not through one of the rosidl generators. The generation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #703