-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If sources list file has default content, exit gracefully #771
Conversation
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
==========================================
- Coverage 74.85% 74.71% -0.15%
==========================================
Files 41 41
Lines 3214 3231 +17
==========================================
+ Hits 2406 2414 +8
- Misses 808 817 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
What’s my next step to get this merged in? |
Maybe we ping @nuclearsandwich @tfoote for review? |
My initial reaction was that invoking rosdep init in a script like
would be a reasonable way to get this feature without a code change but that script assumes the default path would never change and doesn't warn if the contents update so this has obvious advantages. @rotu would you be interested in adding tests for the two reinitialization cases? (same content and changed content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all this needs is tests and then we can merge it.
@nuclearsandwich Feel free to take over this PR |
Thanks, I'm not sure I'll get to it but if anyone wants to see this change merged open a PR with these changes and some tests and I'll review it. |
Fixes ros-tooling/setup-ros#174