Skip to content

Commit 0acfe95

Browse files
Rename class PinholeCameraModel to CameraModel and headers
PinholeCameraModel is misleading now that fisheye model (KB) was introduced. Hence, rename the class and file to a more general name. Class CameraModel does use the distortion model specified in the camera_info, namely pinhole, fisheye and rationa_polynomial
1 parent 447aaf7 commit 0acfe95

File tree

10 files changed

+17
-17
lines changed

10 files changed

+17
-17
lines changed

depth_image_proc/include/depth_image_proc/depth_conversions.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
#include <sensor_msgs/Image.h>
3838
#include <sensor_msgs/point_cloud2_iterator.h>
39-
#include <image_geometry/pinhole_camera_model.h>
39+
#include <image_geometry/camera_model.h>
4040
#include <depth_image_proc/depth_traits.h>
4141

4242
#include <limits>
@@ -50,7 +50,7 @@ template<typename T>
5050
void convert(
5151
const sensor_msgs::ImageConstPtr& depth_msg,
5252
PointCloud::Ptr& cloud_msg,
53-
const image_geometry::PinholeCameraModel& model,
53+
const image_geometry::CameraModel& model,
5454
double range_max = 0.0)
5555
{
5656
// Use correct principal point from calibration

depth_image_proc/src/nodelets/point_cloud_xyz.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#include <nodelet/nodelet.h>
3636
#include <image_transport/image_transport.h>
3737
#include <sensor_msgs/image_encodings.h>
38-
#include <image_geometry/pinhole_camera_model.h>
38+
#include <image_geometry/camera_model.h>
3939
#include <boost/thread.hpp>
4040
#include <depth_image_proc/depth_conversions.h>
4141

@@ -57,7 +57,7 @@ class PointCloudXyzNodelet : public nodelet::Nodelet
5757
typedef sensor_msgs::PointCloud2 PointCloud;
5858
ros::Publisher pub_point_cloud_;
5959

60-
image_geometry::PinholeCameraModel model_;
60+
image_geometry::CameraModel model_;
6161

6262
virtual void onInit();
6363

depth_image_proc/src/nodelets/point_cloud_xyz_radial.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#include <nodelet/nodelet.h>
3636
#include <image_transport/image_transport.h>
3737
#include <sensor_msgs/image_encodings.h>
38-
#include <image_geometry/pinhole_camera_model.h>
38+
#include <image_geometry/camera_model.h>
3939
#include <boost/thread.hpp>
4040
#include <depth_image_proc/depth_traits.h>
4141

depth_image_proc/src/nodelets/point_cloud_xyzi.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
#include <sensor_msgs/image_encodings.h>
4747
#include <sensor_msgs/point_cloud2_iterator.h>
4848
#include <sensor_msgs/PointCloud2.h>
49-
#include <image_geometry/pinhole_camera_model.h>
49+
#include <image_geometry/camera_model.h>
5050
#include <depth_image_proc/depth_traits.h>
5151
#include <cv_bridge/cv_bridge.h>
5252
#include <opencv2/imgproc/imgproc.hpp>
@@ -73,7 +73,7 @@ class PointCloudXyziNodelet : public nodelet::Nodelet
7373
typedef sensor_msgs::PointCloud2 PointCloud;
7474
ros::Publisher pub_point_cloud_;
7575

76-
image_geometry::PinholeCameraModel model_;
76+
image_geometry::CameraModel model_;
7777

7878
virtual void onInit();
7979

depth_image_proc/src/nodelets/point_cloud_xyzi_radial.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
#include <message_filters/subscriber.h>
4040
#include <message_filters/synchronizer.h>
4141
#include <message_filters/sync_policies/exact_time.h>
42-
#include <image_geometry/pinhole_camera_model.h>
42+
#include <image_geometry/camera_model.h>
4343
#include <boost/thread.hpp>
4444
#include <depth_image_proc/depth_traits.h>
4545

depth_image_proc/src/nodelets/point_cloud_xyzrgb.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
#include <sensor_msgs/image_encodings.h>
4848
#include <sensor_msgs/point_cloud2_iterator.h>
4949
#include <sensor_msgs/PointCloud2.h>
50-
#include <image_geometry/pinhole_camera_model.h>
50+
#include <image_geometry/camera_model.h>
5151
#include <depth_image_proc/depth_traits.h>
5252
#include <cv_bridge/cv_bridge.h>
5353
#include <opencv2/imgproc/imgproc.hpp>
@@ -77,7 +77,7 @@ class PointCloudXyzrgbNodelet : public nodelet::Nodelet
7777
typedef sensor_msgs::PointCloud2 PointCloud;
7878
ros::Publisher pub_point_cloud_;
7979

80-
image_geometry::PinholeCameraModel model_;
80+
image_geometry::CameraModel model_;
8181

8282
virtual void onInit();
8383

depth_image_proc/src/nodelets/register.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
#include <tf2_ros/buffer.h>
4242
#include <tf2_ros/transform_listener.h>
4343
#include <sensor_msgs/image_encodings.h>
44-
#include <image_geometry/pinhole_camera_model.h>
44+
#include <image_geometry/camera_model.h>
4545
#include <Eigen/Geometry>
4646
#include <eigen_conversions/eigen_msg.h>
4747
#include <depth_image_proc/depth_traits.h>
@@ -69,7 +69,7 @@ class RegisterNodelet : public nodelet::Nodelet
6969
boost::mutex connect_mutex_;
7070
image_transport::CameraPublisher pub_registered_;
7171

72-
image_geometry::PinholeCameraModel depth_model_, rgb_model_;
72+
image_geometry::CameraModel depth_model_, rgb_model_;
7373

7474
virtual void onInit();
7575

image_proc/include/image_proc/processor.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#define IMAGE_PROC_PROCESSOR_H
3636

3737
#include <opencv2/core/core.hpp>
38-
#include <image_geometry/pinhole_camera_model.h>
38+
#include <image_geometry/camera_model.h>
3939
#include <sensor_msgs/Image.h>
4040

4141
namespace image_proc {
@@ -68,7 +68,7 @@ class Processor
6868
};
6969

7070
bool process(const sensor_msgs::ImageConstPtr& raw_image,
71-
const image_geometry::PinholeCameraModel& model,
71+
const image_geometry::CameraModel& model,
7272
ImageSet& output, int flags = ALL) const;
7373
};
7474

image_proc/src/libimage_proc/processor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ namespace image_proc {
4040
namespace enc = sensor_msgs::image_encodings;
4141

4242
bool Processor::process(const sensor_msgs::ImageConstPtr& raw_image,
43-
const image_geometry::PinholeCameraModel& model,
43+
const image_geometry::CameraModel& model,
4444
ImageSet& output, int flags) const
4545
{
4646
static const int MONO_EITHER = MONO | RECT;

image_proc/src/nodelets/rectify.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
#include <ros/ros.h>
4040
#include <nodelet/nodelet.h>
4141
#include <image_transport/image_transport.h>
42-
#include <image_geometry/pinhole_camera_model.h>
42+
#include <image_geometry/camera_model.h>
4343
#include <cv_bridge/cv_bridge.h>
4444
#include <dynamic_reconfigure/server.h>
4545
#include <image_proc/RectifyConfig.h>
@@ -64,7 +64,7 @@ class RectifyNodelet : public nodelet::Nodelet
6464
Config config_;
6565

6666
// Processing state (note: only safe because we're using single-threaded NodeHandle!)
67-
image_geometry::PinholeCameraModel model_;
67+
image_geometry::CameraModel model_;
6868

6969
virtual void onInit();
7070

0 commit comments

Comments
 (0)