From 87eefdba6cc75c5d9c9d0becfc06e4896436e3c6 Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Thu, 11 Sep 2025 16:49:16 +0200 Subject: [PATCH 1/3] [ci] Enable libc++ for the clang build on Linux explore https://github.com/root-project/root/issues/19850 revive https://github.com/root-project/root/pull/16972 Test https://its.cern.ch/jira/browse/ROOT-10021 --- .github/workflows/root-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml index 029e4de73c02d..e813de3ece4ee 100644 --- a/.github/workflows/root-ci.yml +++ b/.github/workflows/root-ci.yml @@ -412,7 +412,7 @@ jobs: - image: alma10 is_special: true property: "clang Ninja" - overrides: ["CMAKE_C_COMPILER=clang", "CMAKE_CXX_COMPILER=clang++"] + overrides: ["CMAKE_C_COMPILER=clang", "CMAKE_CXX_COMPILER=clang++", "libcxx=ON"] cmake_generator: Ninja # Fedora Rawhide with Python debug build - image: rawhide From 4fc05443309f9e6819df257be0be7fdc47440bba Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Thu, 11 Sep 2025 17:50:32 +0200 Subject: [PATCH 2/3] [ci] try with std 23 --- .github/workflows/root-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml index e813de3ece4ee..86587dae53c81 100644 --- a/.github/workflows/root-ci.yml +++ b/.github/workflows/root-ci.yml @@ -412,7 +412,7 @@ jobs: - image: alma10 is_special: true property: "clang Ninja" - overrides: ["CMAKE_C_COMPILER=clang", "CMAKE_CXX_COMPILER=clang++", "libcxx=ON"] + overrides: ["CMAKE_C_COMPILER=clang", "CMAKE_CXX_COMPILER=clang++", "CMAKE_CXX_STANDARD=23", "libcxx=ON"] cmake_generator: Ninja # Fedora Rawhide with Python debug build - image: rawhide From 4de9698b48e26f4a6cf301d1c70c3a13294c86d8 Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Thu, 11 Sep 2025 23:15:25 +0200 Subject: [PATCH 3/3] Update SearchInstalledSoftware.cmake --- cmake/modules/SearchInstalledSoftware.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/modules/SearchInstalledSoftware.cmake b/cmake/modules/SearchInstalledSoftware.cmake index b55accf14b143..d672894e96c68 100644 --- a/cmake/modules/SearchInstalledSoftware.cmake +++ b/cmake/modules/SearchInstalledSoftware.cmake @@ -2211,7 +2211,7 @@ if(NOT ROOT_HAVE_NATIVE_CXX_FILESYSTEM) set(CMAKE_REQUIRED_LIBRARIES stdc++fs) check_cxx_source_compiles("${_filesystem_source}" ROOT_NEED_STDCXXFS) if(NOT ROOT_NEED_STDCXXFS) - message(FATAL_ERROR "Could not determine how to use C++17 ") + message(WARNING "Could not determine how to use C++17 ") endif() endif()